From 361aba2c2effa9c131ed753e1f01cfb030f78f6e Mon Sep 17 00:00:00 2001 From: Max Elkins Date: Tue, 17 Jun 2025 16:37:08 +0100 Subject: [PATCH 1/7] fix: change `block-size` to `min-block-size` to allow height to grow also change to correct custom property to ensure minimum target size --- src/assets/stylesheets/Tabs.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/assets/stylesheets/Tabs.scss b/src/assets/stylesheets/Tabs.scss index beb3856e3..636bca3c3 100644 --- a/src/assets/stylesheets/Tabs.scss +++ b/src/assets/stylesheets/Tabs.scss @@ -19,7 +19,7 @@ margin: 0; inset-block-start: 0; inset-block-end: 0; - block-size: $space-3; + min-block-size: var(--min-target-size); box-sizing: border-box; display: flex; align-items: center; From 0af385e87e63423b3bf57ed75fd2a0081c966231 Mon Sep 17 00:00:00 2001 From: Max Elkins Date: Tue, 17 Jun 2025 16:59:55 +0100 Subject: [PATCH 2/7] docs: changelog update --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 515a34d4c..4df2ec7cf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), - Styling issue on sidebar on mobile (#1194) - Styling issue preventing scrolling in the sidebar (#1216) +- Change tab `block-size` to `min-block-size` to allow for height increase when text wraps (#1219) ## [0.30.0] - 2025-04-15 From a330a9923bb145d9dcbcca02d0cf040337c6315b Mon Sep 17 00:00:00 2001 From: Max Elkins Date: Tue, 17 Jun 2025 17:30:32 +0100 Subject: [PATCH 3/7] fix: changelog error --- CHANGELOG.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4df2ec7cf..02d27f390 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ## Unreleased +## Fixed + +- Styling issue preventing scrolling in the sidebar (#1216) +- Change tab `block-size` to `min-block-size` to allow for height increase when text wraps (#1219) + ## [0.30.1] - 2025-06-09 ### Added @@ -19,8 +24,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ### Fixed - Styling issue on sidebar on mobile (#1194) -- Styling issue preventing scrolling in the sidebar (#1216) -- Change tab `block-size` to `min-block-size` to allow for height increase when text wraps (#1219) ## [0.30.0] - 2025-04-15 From 65f039ccc713defc057bc4e22e90bef4e1968f1f Mon Sep 17 00:00:00 2001 From: Max Elkins Date: Wed, 18 Jun 2025 16:08:03 +0100 Subject: [PATCH 4/7] fix: change hiding implmentation to use display rather than height/block-size - Switched from manipulating `block-size` to `display: none` for more robust and explicit hiding of the visual output panel and its corresponding tab. - Ensures elements are truly removed from the layout, preventing subtle rendering issues and improving reliability for Cypress visibility assertions --- .../Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx b/src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx index 3fbe45cfe..670fb34dc 100644 --- a/src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx +++ b/src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx @@ -485,7 +485,7 @@ const SkulptRunner = ({ active, outputPanels = ["text", "visual"] }) => { {showVisualOutputPanel && (
{ >
- + {t("output.visualOutput")} From f4deefa3120ad34c4c5a312fae1c18cd0f158571 Mon Sep 17 00:00:00 2001 From: Max Elkins Date: Wed, 18 Jun 2025 16:14:10 +0100 Subject: [PATCH 5/7] style: linting --- .../Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx b/src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx index 670fb34dc..0e19c63c7 100644 --- a/src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx +++ b/src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx @@ -551,7 +551,8 @@ const SkulptRunner = ({ active, outputPanels = ["text", "visual"] }) => { + style={{ display: showVisualOutput ? undefined : "none" }} + > {t("output.visualOutput")} From 966f63ee287450220002a33154c27dac8b6a919b Mon Sep 17 00:00:00 2001 From: Max Elkins Date: Wed, 18 Jun 2025 16:38:21 +0100 Subject: [PATCH 6/7] docs: update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e1c50ef7f..5e729f500 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), - Styling issue preventing scrolling in the sidebar (#1216) - Styling issue on status bar on mobile (#1217) - Change tab `block-size` to `min-block-size` to allow for height increase when text wraps (#1219) +- Changed `SkulptRunner.jsx` implementation of hiding elements to used `display: none` rather than `block-size: 0` (#1219) ## [0.30.1] - 2025-06-09 From 4de8f80e4f794aa950ef6a6fc8d716703eb415d5 Mon Sep 17 00:00:00 2001 From: Max Elkins Date: Wed, 18 Jun 2025 16:38:55 +0100 Subject: [PATCH 7/7] refactor: typo --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e729f500..f67e70400 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), - Styling issue preventing scrolling in the sidebar (#1216) - Styling issue on status bar on mobile (#1217) - Change tab `block-size` to `min-block-size` to allow for height increase when text wraps (#1219) -- Changed `SkulptRunner.jsx` implementation of hiding elements to used `display: none` rather than `block-size: 0` (#1219) +- Changed `SkulptRunner.jsx` implementation of hiding elements to use `display: none` rather than `block-size: 0` (#1219) ## [0.30.1] - 2025-06-09