Skip to content

fix: change tab block-size to min-block-size to allow height to grow #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxelkins merged 8 commits into from
Jun 18, 2025
Merged

fix: change tab block-size to min-block-size to allow height to grow #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
361aba2
fix: change `block-size` to `min-block-size` to allow height to grow
maxelkins Jun 17, 2025
0af385e
docs: changelog update
maxelkins Jun 17, 2025
a330a99
fix: changelog error
maxelkins Jun 17, 2025
0179c9c
Merge branch 'main' into preview-in-new-tab-causing-wrapping
maxelkins Jun 18, 2025
65f039c
fix: change hiding implmentation to use display rather than height/bl…
maxelkins Jun 18, 2025
f4deefa
style: linting
maxelkins Jun 18, 2025
966f63e
docs: update changelog
maxelkins Jun 18, 2025
4de8f80
refactor: typo
maxelkins Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## Unreleased

## Fixed

- Styling issue preventing scrolling in the sidebar (#1216)
- Styling issue on status bar on mobile (#1217)
- Change tab `block-size` to `min-block-size` to allow for height increase when text wraps (#1219)
- Changed `SkulptRunner.jsx` implementation of hiding elements to use `display: none` rather than `block-size: 0` (#1219)

## [0.30.1] - 2025-06-09

### Added
Expand All @@ -19,8 +26,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Fixed

- Styling issue on sidebar on mobile (#1194)
- Styling issue preventing scrolling in the sidebar (#1216)
- Styling issue on status bar on mobile (#1217)

## [0.30.0] - 2025-04-15

Expand Down
2 changes: 1 addition & 1 deletion src/assets/stylesheets/Tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
margin: 0;
inset-block-start: 0;
inset-block-end: 0;
block-size: $space-3;
min-block-size: var(--min-target-size);
box-sizing: border-box;
display: flex;
align-items: center;
Expand Down
7 changes: 5 additions & 2 deletions src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ const SkulptRunner = ({ active, outputPanels = ["text", "visual"] }) => {
{showVisualOutputPanel && (
<div
className={outputPanelClasses("visual")}
style={{ blockSize: showVisualOutput ? "auto" : 0 }}
style={{ display: showVisualOutput ? undefined : "none" }}
>
<Tabs forceRenderTabPanel={true}>
<div
Expand Down Expand Up @@ -549,7 +549,10 @@ const SkulptRunner = ({ active, outputPanels = ["text", "visual"] }) => {
>
<div className="react-tabs__tab-container">
<TabList>
<Tab key={0} style={{ blockSize: showVisualOutput ? "auto" : 0 }}>
<Tab
key={0}
style={{ display: showVisualOutput ? undefined : "none" }}
>
<span className="react-tabs__tab-text">
{t("output.visualOutput")}
</span>
Expand Down
Loading