Plugin system for sidebar panels#1251
Merged
Merged
Conversation
loiswells97
temporarily deployed
to
previews/1251/merge
October 6, 2025 15:56 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1251/merge
October 6, 2025 16:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1251/merge
October 7, 2025 13:19 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adrian-rpf
reviewed
Oct 7, 2025
adrian-rpf
left a comment
adrian-rpf
left a comment
Contributor
There was a problem hiding this comment.
I really like this code. Really nice and clear.
-
Should we consider the naming of some of the variables. Limiting or making it clear that that it's for use for the sidebar.
-
How will we document how to use this plugin system? ReadMe, Example Plugin Script?
| withProjectbar = true, | ||
| withSidebar = true, | ||
| sidebarOptions = [], | ||
| plugins = [], |
Contributor
There was a problem hiding this comment.
wondering if we should name this sidebarPlugins to limit scope/.
adrian-rpf
approved these changes
Oct 7, 2025
adrian-rpf
left a comment
adrian-rpf
left a comment
Contributor
There was a problem hiding this comment.
Really nice change and good plan.
We have discussed this needs documenting/creating an example at a later point.
rammodhvadia
added a commit
that referenced
this pull request
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.