Fix the HTML preview locally#1456
Open
zetter-rpf wants to merge 1 commit intomainfrom
Open
Conversation
In production we have a cloudflare rule that allows cross-origin requests. Without this the iframe does not render in Chrome.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the local webpack dev server configuration so the HTML preview iframe can render locally (matching production’s cross-origin behavior managed by Cloudflare).
Changes:
- Extend the devServer middleware to set
Cross-Origin-Resource-Policy: cross-originforhtml-renderer.html.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@abcampo-iry thought you would be a good reviewer as you had the same problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1379
In production we have a cloudflare rule that allows cross-origin requests. Without this the iframe does not render in locally (tested in Chrome).