Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused Plausible-related environment variables from this repo’s example environment file and GitHub Actions workflows, reducing configuration ambiguity while keeping editor-ui analytics event emission unchanged (still via window.plausible(...) provided by editor-standalone).
Changes:
- Removed
react_app_plausible_*workflow inputs and correspondingREACT_APP_PLAUSIBLE_*build env wiring from the deploy workflow. - Removed
REACT_APP_PLAUSIBLE_SOURCEfrom CI Cypress job environment. - Removed
REACT_APP_PLAUSIBLE_DATA_DOMAIN/REACT_APP_PLAUSIBLE_SOURCEfrom.env.example.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/deploy.yml |
Drops unused Plausible workflow inputs and build-time env vars to avoid misleading configuration. |
.github/workflows/ci-cd.yml |
Removes an unused Plausible env var from the Cypress CI job and stops passing Plausible inputs to the deploy workflow. |
.env.example |
Removes unused Plausible env vars from the sample local configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zetter-rpf
approved these changes
May 8, 2026
Contributor
zetter-rpf
left a comment
There was a problem hiding this comment.
Thanks for tidying up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to 1344
This PR does NOT change analytics behaviour in
editor-ui- it removes environment variables that are not wired intoeditor-uianalytics and could cause confusion.What changed
editor-ui.Why the env vars aren’t needed
editor-standalone.editor-uievent emission continues to work through that integration, using window.plausible() provided byeditor-standalone.editor-uievent dispatch.What this means
editor-uiremains the source of UI event calls.editor-standaloneremains responsible for loading/configuring Plausible.Checks
window.plausible(...)calls fire from editor-ui actions in local development, using the window.plausible function established byeditor-standalone.