Skip to content

1344: remove unneeded plausible env vars#1460

Merged
DNR500 merged 1 commit intomainfrom
1344-remove-unused-plausible-env-var
May 8, 2026
Merged

1344: remove unneeded plausible env vars#1460
DNR500 merged 1 commit intomainfrom
1344-remove-unused-plausible-env-var

Conversation

@DNR500
Copy link
Copy Markdown
Contributor

@DNR500 DNR500 commented May 8, 2026

Relates to 1344

This PR does NOT change analytics behaviour in editor-ui -  it removes environment variables that are not wired into editor-ui analytics and could cause confusion.

What changed

  • No functional changes were introduced to Plausible event names or event trigger points in editor-ui.
  • We validated that key UI actions are still calling window.plausible(...) as expected.

Why the env vars aren’t needed

  • Analytics bootstrap/config changes are handled in editor-standalone.
  • editor-ui event emission continues to work through that integration, using window.plausible() provided by editor-standalone.
  • The env vars removed in this PR are not actually connected to editor-ui event dispatch.


What this means

  • editor-ui remains the source of UI event calls.
  • editor-standalone remains responsible for loading/configuring Plausible.
  • This preserves existing tracking behaviour while reducing config ambiguity.

Checks

  • Confirmed window.plausible(...) calls fire from editor-ui actions in local development, using the window.plausible function established by editor-standalone.

@DNR500 DNR500 self-assigned this May 8, 2026
@DNR500 DNR500 marked this pull request as ready for review May 8, 2026 11:37
Copilot AI review requested due to automatic review settings May 8, 2026 11:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused Plausible-related environment variables from this repo’s example environment file and GitHub Actions workflows, reducing configuration ambiguity while keeping editor-ui analytics event emission unchanged (still via window.plausible(...) provided by editor-standalone).

Changes:

  • Removed react_app_plausible_* workflow inputs and corresponding REACT_APP_PLAUSIBLE_* build env wiring from the deploy workflow.
  • Removed REACT_APP_PLAUSIBLE_SOURCE from CI Cypress job environment.
  • Removed REACT_APP_PLAUSIBLE_DATA_DOMAIN / REACT_APP_PLAUSIBLE_SOURCE from .env.example.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/deploy.yml Drops unused Plausible workflow inputs and build-time env vars to avoid misleading configuration.
.github/workflows/ci-cd.yml Removes an unused Plausible env var from the Cypress CI job and stops passing Plausible inputs to the deploy workflow.
.env.example Removes unused Plausible env vars from the sample local configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@zetter-rpf zetter-rpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying up!

@DNR500 DNR500 merged commit 44a63ff into main May 8, 2026
11 checks passed
@DNR500 DNR500 deleted the 1344-remove-unused-plausible-env-var branch May 8, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants