Improve output panels with error messages#1505
Open
cocomarine wants to merge 4 commits into
Open
Conversation
…and add border to error message
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Python runner output panel layout so the visual and text output panes split more evenly in small containers and follow a 3:2 split in larger containers, and updates the error message styling to show borders on both block edges.
Changes:
- Update
.output-panel--text/.output-panel--visualflex ratios for small vs larger containers using container queries. - Add a minimum block size to the selected tab panel in the text output area.
- Change error message border from
border-block-starttoborder-block.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/assets/stylesheets/PythonRunner.scss |
Changes output panel flex ratios and adds a minimum height rule for the selected text tab panel. |
src/assets/stylesheets/ErrorMessage.scss |
Adjusts error message border styling to apply on both block edges. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1512
Changes
In smaller project container (
.project-wrappercontainer in Project.scss):In larger container (min-width: 720px):