Fix vertical accel#346
Open
lexm2 wants to merge 1 commit into
Open
Conversation
MapProfileModelToDriver populated argsX but never argsY, so the Y axis defaulted to noaccel. In by-component mode this left vertical movement with no acceleration while horizontal accelerated. Set argsY from the same single acceleration curve the UI exposes (one MapToDriver() call per axis so each AccelArgs gets its own LUT data array). Also default CombineXYComponents to true to match upstream RawAccel, so new profiles use whole/combined accel out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapProfileModelToDriver populated argsX but never argsY, so the Y axis defaulted to noaccel. In component mode this left vertical movement with no acceleration while horizontal accelerated.
Also default CombineXYComponents to true to match the old UI, so new profiles use combined accel out of the box.