Skip to content

Commit 6efaf37

Browse files
committed
cleanup merge
1 parent 0d02508 commit 6efaf37

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

src/dogroups.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,9 @@ SEXP dogroups(SEXP dt, SEXP dtcols, SEXP groups, SEXP grpcols, SEXP jiscols, SEX
8585
// fix for longstanding FR/bug, #495. E.g., DT[, c(sum(v1), lapply(.SD, mean)), by=grp, .SDcols=v2:v3] resulted in error.. the idea is, 1) we create .SDall, which is normally == .SD. But if extra vars are detected in jexp other than .SD, then .SD becomes a shallow copy of .SDall with only .SDcols in .SD. Since internally, we don't make a copy, changing .SDall will reflect in .SD. Hopefully this'll workout :-).
8686
SEXP SDall = PROTECT(findVar(install(".SDall"), env)); nprotect++; // PROTECT for rchk
8787
SEXP SD = PROTECT(findVar(install(".SD"), env)); nprotect++;
88-
<<<<<<< HEAD
89-
88+
9089
int updateTime = INTEGER(showProgressArg)[0];
9190
const bool showProgress = updateTime > 0 && ngrp > 1; // showProgress only if more than 1 group
92-
=======
93-
94-
const bool showProgress = LOGICAL(showProgressArg)[0]==1 && ngrp > 1; // showProgress only if more than 1 group
95-
>>>>>>> master
9691
double startTime = (showProgress) ? wallclock() : 0; // For progress printing, startTime is set at the beginning
9792
double nextTime = (showProgress) ? startTime + MAX(updateTime, 3) : 0; // wait at least 3 seconds before printing progress
9893

0 commit comments

Comments
 (0)