Skip to content

Commit c582969

Browse files
committed
Fix Trailing White Space, Add NEWS item for #7099
1 parent bcf716e commit c582969

3 files changed

Lines changed: 15 additions & 3 deletions

File tree

..Rcheck/00check.log

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
* using log directory ‘/home/skit/data.table/..Rcheck’
2+
* using R version 3.5.0 (2018-04-23)
3+
* using platform: x86_64-pc-linux-gnu (64-bit)
4+
* using session charset: UTF-8
5+
* using option ‘--no-manual’
6+
* checking for file ‘./DESCRIPTION’ ... ERROR
7+
Required fields missing or empty:
8+
‘Author’ ‘Maintainer’
9+
* DONE
10+
Status: 1 ERROR

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@
5050

5151
8. `test()` now reports multiple expected warnings more clearly when `warning=` has length greater than 1L, instead of printing a collapsed or repeated mismatch summary after messages like `Test 1 produced 1 warnings but expected 2`, [#7092](https://github.com/Rdatatable/data.table/issues/7092). Expected and observed warnings are now printed on separate aligned lines, making small differences easier to spot. Thanks @MichaelChirico for the report, @ben-schwen for assistance, and @lucaslarson25, @tjdavis51, @D3VTHSTVR, and @car723 for the fix.
5252

53+
11. `fread()` now correctly preserves empty trailing fields when `fill=TRUE` is used with irregular rows, [#7099](https://github.com/Rdatatable/data.table/issues/7099). Thanks to @aitap for the report and @skitsy24 for the fix.
54+
5355
### Notes
5456

5557
1. {data.table} now depends on R 3.5.0 (2018).

R/print.data.table.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ print.data.table = function(x, topn=getOption("datatable.print.topn"),
2222
stopifnot(isTRUEorFALSE(class))
2323
if (col.names == "none" && class)
2424
warningf("Column classes will be suppressed when col.names is 'none'")
25-
25+
2626
if (!shouldPrint(x)) {
2727
# := in [.data.table sets .global$print=address(x) to suppress the next print i.e., like <- does. See FAQ 2.22 and README item in v1.9.5
2828
# The issue is distinguishing "> DT" (after a previous := in a function) from "> DT[,foo:=1]". To print.data.table(), there
@@ -41,8 +41,8 @@ print.data.table = function(x, topn=getOption("datatable.print.topn"),
4141
is_print_call = FALSE
4242
if (identical(SYS[[1L]][[1L]], print)) {
4343
is_print_call = TRUE
44-
}
45-
# nocov start
44+
}
45+
# nocov start
4646
else if (typeof(SYS[[1L]][[1L]]) == "promise") {
4747
# in R 3.4 and R 3.5, auto-print uses a promise to reference base::print due to lazy loading
4848
# safely evaluate promise to get the actual function

0 commit comments

Comments
 (0)