Keep listNames protected

aitap · aitap · commit f2b8c58ee9ea · 2026-06-18T15:10:29.000+03:00
diff --git a/src/rbindlist.c b/src/rbindlist.c
@@ -250,7 +250,7 @@ SEXP rbindlist(SEXP l, SEXP usenamesArg, SEXP fillArg, SEXP idcolArg, SEXP ignor
   setAttrib(ans, R_NamesSymbol, ansNames);
   if (idcol) {
     SET_STRING_ELT(ansNames, 0, STRING_ELT(idcolArg, 0));
-    SEXP idval, listNames=getAttrib(l, R_NamesSymbol);
+    SEXP idval, listNames=PROTECT(getAttrib(l, R_NamesSymbol));
     if (length(listNames)) {
       SET_VECTOR_ELT(ans, 0, idval=allocVector(STRSXP, nrow));
       for (int i=0,ansloc=0; i<LENGTH(l); ++i) {
@@ -270,6 +270,7 @@ SEXP rbindlist(SEXP l, SEXP usenamesArg, SEXP fillArg, SEXP idcolArg, SEXP ignor
         for (int k=0; k<thisnrow; ++k) idvald[ansloc++] = i+1;
       }
     }
+    UNPROTECT(1); // listNames
   }
 
   PROTECT_INDEX IcoercedForFactor;

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ SEXP rbindlist(SEXP l, SEXP usenamesArg, SEXP fillArg, SEXP idcolArg, SEXP ignor`
`250`	`250`	`setAttrib(ans, R_NamesSymbol, ansNames);`
`251`	`251`	`if (idcol) {`
`252`	`252`	`SET_STRING_ELT(ansNames, 0, STRING_ELT(idcolArg, 0));`
`253`		`- SEXP idval, listNames=getAttrib(l, R_NamesSymbol);`
	`253`	`+ SEXP idval, listNames=PROTECT(getAttrib(l, R_NamesSymbol));`
`254`	`254`	`if (length(listNames)) {`
`255`	`255`	`SET_VECTOR_ELT(ans, 0, idval=allocVector(STRSXP, nrow));`
`256`	`256`	`for (int i=0,ansloc=0; i<LENGTH(l); ++i) {`
`@@ -270,6 +270,7 @@ SEXP rbindlist(SEXP l, SEXP usenamesArg, SEXP fillArg, SEXP idcolArg, SEXP ignor`
`270`	`270`	`for (int k=0; k<thisnrow; ++k) idvald[ansloc++] = i+1;`
`271`	`271`	`}`
`272`	`272`	`}`
	`273`	`+ UNPROTECT(1); // listNames`
`273`	`274`	`}`
`274`	`275`
`275`	`276`	`PROTECT_INDEX IcoercedForFactor;`