Skip to content

Slightly more robust pull of .Machine entries#6154

Merged
ben-schwen merged 3 commits into
masterfrom
machine-unknown
Jun 30, 2025
Merged

Slightly more robust pull of .Machine entries#6154
ben-schwen merged 3 commits into
masterfrom
machine-unknown

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Related to #6153, getting longdouble.digits== is not the most helpful, I think there's a couple ways we could get that. I assume based on the base R code that we're seeing NULL there, but this will help clarify the actual value / rely less on inference.

@MichaelChirico
Copy link
Copy Markdown
Member Author

format() will at least let us distinguish integer() from NULL.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2024

Comparison Plot

Generated via commit 2eeb415

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 44 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 18 seconds

@ben-schwen
Copy link
Copy Markdown
Member

Maybe also add capabilities()["long.double"]?

@MichaelChirico
Copy link
Copy Markdown
Member Author

I guess that's overkill, here's how that element of capabilities() is defined:

https://github.com/r-devel/r-svn/blob/e0f5c5e1c60bca2b7b2044eb0b4770e287cd770e/src/main/platform.c#L2627-L2628

Here's the LDOUBLE macro:

https://github.com/r-devel/r-svn/blob/1f537a2469956b505ad10135eeee282fe33a8475/src/include/Defn.h#L2407-L2411

In turn I think HAVE_LONG_DOUBLE gets set by ./configure.

Here's how .Machine$sizeof.longdouble is defined:

https://github.com/r-devel/r-svn/blob/1f537a2469956b505ad10135eeee282fe33a8475/src/main/machine.c#L139-L144

Here's the SIZEOF_LONG_DOUBLE macro:

https://github.com/r-devel/r-svn/blob/1f537a2469956b505ad10135eeee282fe33a8475/src/gnuwin32/fixed/h/config.h#L1182-L1191

So there might be some daylight between the two, WDYT?

Comment thread R/test.data.table.R
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (6f3fc8d) to head (fd41733).
Report is 778 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6154      +/-   ##
==========================================
+ Coverage   97.51%   98.69%   +1.18%     
==========================================
  Files          80       79       -1     
  Lines       14979    14679     -300     
==========================================
- Hits        14607    14488     -119     
+ Misses        372      191     -181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen ben-schwen merged commit 48cb609 into master Jun 30, 2025
11 of 12 checks passed
@ben-schwen ben-schwen deleted the machine-unknown branch June 30, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants