formatting improvements in fread

[badasahog]

The last time I tried to do this, I got yelled at for creating conflicts. Hopefully fread is less actively worked on, so it won't create a gridlock.

Once this is done, I'll work on #6995 and #6971, as well as the creation of helper functions to reduce the overall complexity.

Open to feedback, of course.

[github-actions]

• HEAD=freadReformat stopped early for fread disk overhead improved in #6925
  

Generated via commit 5b9133b

Download link for the artifact containing the test results: ↓ atime-results.zip

Task	Duration
R setup and installing dependencies	2 minutes and 39 seconds
Installing different package versions	38 seconds
Running and plotting the test cases	2 minutes and 43 seconds

[TysonStanley]

Thanks, @badasahog! Very much appreciate you doing this for fread. Over time we'll be able to expand this to the rest of the code set.

[badasahog]

My main concern is if this takes too long to merge. That's the main bottleneck for me.

[jangorecki]

Merging PR in this repo used to be 3 weeks to 3 months process for couple years. Considering there is no funding dedicated for reviewing and merging PR the process goes pretty smooth. Of course there is always space for improvement. It is far from how it could look like if there would be a full time dev in the project.

[MichaelChirico]

LGTM, thank you!

Main thing is about whether we should remove the precedence-clarifying parentheses in *(obj->elt).

[MichaelChirico]

Reviewed in two passes: Once in the plain 'files' pane, then again with whitespace differences ignored:

https://github.com/Rdatatable/data.table/pull/7074/files?w=1

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (e32e553) to head (5b9133b).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7074   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          79       79           
  Lines       14680    14680           
=======================================
  Hits        14489    14489           
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.