Skip to content

Handle get0() in setDT() to preserve .internal.selfref #7101

Merged
MichaelChirico merged 9 commits into
masterfrom
issue__6864
Jun 26, 2025
Merged

Handle get0() in setDT() to preserve .internal.selfref #7101
MichaelChirico merged 9 commits into
masterfrom
issue__6864

Conversation

@venom1204
Copy link
Copy Markdown
Contributor

closes #6864

hi in this pr I

  • Extend setDT() to handle get0() calls (like it does for get()).
  • Fix: added get0 to name %iscall% c("get", "get0").

hi @MichaelChirico can you please review this when you have time.

thank you

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (6a6147e) to head (27aad20).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7101   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          79       79           
  Lines       14680    14680           
=======================================
  Hits        14489    14489           
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 26, 2025

  • HEAD=issue__6864 stopped early for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit 27aad20

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 48 seconds
Installing different package versions 38 seconds
Running and plotting the test cases 2 minutes and 25 seconds

@MichaelChirico
Copy link
Copy Markdown
Member

Thanks! Please add a test and NEWS item

@venom1204
Copy link
Copy Markdown
Contributor Author

done

Comment thread NEWS.md Outdated
Comment thread inst/tests/tests.Rraw Outdated
Comment thread inst/tests/tests.Rraw Outdated
Comment thread inst/tests/tests.Rraw Outdated
@MichaelChirico MichaelChirico merged commit 5bb6450 into master Jun 26, 2025
12 checks passed
@MichaelChirico MichaelChirico deleted the issue__6864 branch June 26, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setDT not always sets ".internal.selfref"

2 participants