Skip to content

Use setattr to avoid shallow copy in autoprint test setup#7102

Merged
jangorecki merged 2 commits into
masterfrom
print-setattr
Jun 27, 2025
Merged

Use setattr to avoid shallow copy in autoprint test setup#7102
jangorecki merged 2 commits into
masterfrom
print-setattr

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Jun 26, 2025

Part of #7099

@MichaelChirico MichaelChirico changed the title Try setattr to avoid shallow copy Use setattr to avoid shallow copy in autoprint test setup Jun 26, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (b19acf1) to head (7425fb4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7102   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          79       79           
  Lines       14680    14680           
=======================================
  Hits        14489    14489           
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jangorecki

This comment was marked as off-topic.

@MichaelChirico

This comment was marked as off-topic.

@jangorecki

This comment was marked as off-topic.

@MichaelChirico

This comment was marked as off-topic.

@jangorecki

This comment was marked as off-topic.

@jangorecki
Copy link
Copy Markdown
Member

jangorecki commented Jun 26, 2025

Two of dependencies could not be installed in this job

Warning message:
packages ‘xts’, ‘knitr’ are not available (for R version 3.4.0) 

warning is gone but problem with matching output is still there, maybe for 3.4.0 we need different mockup file.
https://gitlab.com/Rdatatable/data.table/-/jobs/10484872441

https://gitlab.com/Rdatatable/data.table/-/jobs/10484872441/artifacts/browse/bus/test-lin-ancient-cran/data.table.Rcheck/tests/

@jangorecki
Copy link
Copy Markdown
Member

jangorecki commented Jun 26, 2025

Looks like

DT[2,a:=3L]

(amongst others) prints in 3.4.0

@MichaelChirico
Copy link
Copy Markdown
Member Author

Thanks. Looks like this is an improvement, but doesn't fix the issue. I think worth merging anyway.

@jangorecki
Copy link
Copy Markdown
Member

yes, worth merging. Assuming R 3.5.0 is not being affected I think we could ignore the printing issue for R 3.4.0. At least till nobody reported that till now.

@jangorecki jangorecki merged commit ab7c931 into master Jun 27, 2025
11 checks passed
@jangorecki jangorecki deleted the print-setattr branch June 27, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants