feat(SMS-102): add otp service and models#3
Merged
Conversation
julesmarche
reviewed
Jun 5, 2025
Contributor
julesmarche
left a comment
julesmarche
left a comment
There was a problem hiding this comment.
Pas grand chose à dire, seulement du détail
|
|
||
| String responseBody = response.getBody(); | ||
|
|
||
| return reSMSMapper.fromJson(responseBody, VerifyOtpResponse.class); |
Contributor
There was a problem hiding this comment.
variable inutile, passe direct response.getbody()
| "Failed to create otp: " + response.getCode() + " " + response.getBody()); | ||
| } | ||
|
|
||
| String responseBody = response.getBody(); |
Contributor
There was a problem hiding this comment.
variable inutile, passe direct response.getbody()
|
|
||
| String responseBody = response.getBody(); | ||
|
|
||
| return reSMSMapper.fromJson(responseBody, CreateOtpResponse.class); |
Contributor
There was a problem hiding this comment.
variable inutile, passe direct response.getbody()
| * @return The response indicating the status of the OTP creation. | ||
| * @throws ReSMSException If an error occurs while creating the OTP. | ||
| */ | ||
| public CreateOtpResponse create(CreateOtpResponse createOtpResponse) throws ReSMSException { |
Contributor
There was a problem hiding this comment.
Pourquoi create() prend en param un objet de type CreateOtpResponse .
Est ce une erreur de nom de classe ? J'aurai plutôt mis par exemple CreateOtpRequest
julesmarche
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.