feat: unify importers#3436

Open

mostafaNazari702 wants to merge 11 commits into

ReVanced:devfrom

mostafaNazari702:feat/unify-importers

mostafaNazari702 commented Jun 28, 2026

No description provided.

mostafaNazari702 changed the title ~~feat(import): introduce transport handler abstraction~~ feat: unify importers

mostafaNazari702 closed this

mostafaNazari702 force-pushed the feat/unify-importers branch from 8cf92f3 to 2a88257 Compare

July 11, 2026 18:46

mostafaNazari702 reopened this

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/protocol/ProtocolHandler.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/protocol/ProtocolHandler.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/protocol/ProtocolHandler.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/network/service/HttpService.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/network/service/HttpService.kt Outdated

oSumAtrIX commented Jul 15, 2026

Member

Next steps after review can concern with registering the handlers or getting rid of the "Local" and "Remote" concept by merging both into one. A local and remote source of patches therefore becomes identical in shape and behaviour.

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/di/ServiceModule.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/protocol/ProtocolHandler.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/protocol/ProtocolHandler.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/protocol/ProtocolHandler.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/protocol/ProtocolHandler.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/protocol/ProtocolHandler.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/network/service/HttpService.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/network/service/HttpService.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/MainActivity.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/MainActivity.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/MainActivity.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/MainActivity.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/UiRequestHost.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/UiRequestHost.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/UiRequestHost.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/UiRequestHost.kt Outdated

app/src/main/java/app/revanced/manager/util/UiRequest.kt Outdated

app/src/main/java/app/revanced/manager/util/UiRequest.kt Outdated

app/src/main/java/app/revanced/manager/ui/component/UiRequestHost.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/manager/SourceManager.kt

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/di/ServiceModule.kt Outdated

mostafaNazari702 added 2 commits

July 16, 2026 20:41


          introduce protocol handlers for opening source streams

bb8d014


          redesign stream access around callbacks and complete the file protoco…

81bef8b

…l handler

mostafaNazari702 added 7 commits

July 16, 2026 20:41


          move UI requests into a generic communication layer

a9e8048


          specialize the request layer to file picking

3c664f3


          parse sources as URIs and route remote transport through protocol han…

783c703

…dlers


          turn the default source into a plain URL

caa7808


          route local imports through the protocol handlers

844dce7


          merge local and remote sources into one

85ef81b


          provide the content resolver through the koin graph

9ea6088

mostafaNazari702 force-pushed the feat/unify-importers branch from 7e3cd9a to 9ea6088 Compare

July 16, 2026 19:17

mostafaNazari702 commented Jul 16, 2026

Author

move UI requests into a generic communication layer => route local imports through the protocol handlers = Rebase.

mostafaNazari702 commented Jul 16, 2026

Author

Need review on my commits merge local and remote sources into one + provide the content resolver through the koin graph

mostafaNazari702 requested a review from oSumAtrIX

July 16, 2026 19:19

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/sources/Source.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/sources/Source.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/data/room/sources/Source.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/domain/sources/Source.kt Outdated

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/di/ServiceModule.kt

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/FilePickerRequestHost.kt

oSumAtrIX reviewed

View reviewed changes

app/src/main/java/app/revanced/manager/ui/screen/settings/DownloadersInfoScreen.kt Outdated

mostafaNazari702 added 2 commits

July 17, 2026 23:07


          remove the local and remote distinction outside the handlers

9d5de81


          store sources as plain URLs and migrate old rows on boot

602a23c

mostafaNazari702 requested a review from oSumAtrIX

July 17, 2026 21:39

oSumAtrIX mentioned this pull request

feat: Implement github as a remote source #3281

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet