Skip to content

Commit 6c0d701

Browse files
committed
test: wait for /app
1 parent 07b024d commit 6c0d701

File tree

4 files changed

+7
-21
lines changed

4 files changed

+7
-21
lines changed
Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,13 @@
11
services:
22
tomcat:
33
image: tomcat:10.1-jre11
4-
networks:
5-
- app_network
64
volumes:
75
- ../../../vul/vul-webapp-jakarta/build/libs/vul-webapp-jakarta.war:/usr/local/tomcat/webapps/app.war
86
nginx:
97
image: nginx:latest
108
ports:
119
- "80:80"
12-
networks:
13-
- app_network
1410
volumes:
1511
- ./nginx.conf:/etc/nginx/nginx.conf:ro
1612
depends_on:
17-
- tomcat
18-
networks:
19-
app_network:
20-
driver: bridge
13+
- tomcat
Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,13 @@
11
services:
22
tomcat:
33
image: tomcat:8-jre8
4-
networks:
5-
- app_network
64
volumes:
75
- ../../../vul/vul-webapp/build/libs/vul-webapp.war:/usr/local/tomcat/webapps/app.war
86
nginx:
97
image: nginx:latest
108
ports:
119
- "80:80"
12-
networks:
13-
- app_network
1410
volumes:
1511
- ./nginx.conf:/etc/nginx/nginx.conf:ro
1612
depends_on:
17-
- tomcat
18-
networks:
19-
app_network:
20-
driver: bridge
13+
- tomcat

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/tomcat/Tomcat10WebSocketBypassNginxTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@
1111
import com.reajason.javaweb.packer.Packers;
1212
import lombok.extern.slf4j.Slf4j;
1313
import org.apache.commons.lang3.tuple.Pair;
14+
import org.junit.jupiter.api.AfterAll;
1415
import org.junit.jupiter.api.Test;
1516
import org.objectweb.asm.Opcodes;
1617
import org.testcontainers.containers.ComposeContainer;
18+
import org.testcontainers.containers.wait.strategy.Wait;
1719
import org.testcontainers.junit.jupiter.Container;
1820
import org.testcontainers.junit.jupiter.Testcontainers;
1921

@@ -35,6 +37,7 @@ public class Tomcat10WebSocketBypassNginxTest {
3537
@Container
3638
public static final ComposeContainer compose =
3739
new ComposeContainer(new File("docker-compose/tomcat/docker-compose-10.1-jre11-nginx.yaml"))
40+
.withExposedService("tomcat", 8080, Wait.forHttp("/app/"))
3841
.withExposedService("nginx", 80);
3942

4043
@Test

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/tomcat/Tomcat8WebSocketBypassNginxTest.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import org.junit.jupiter.api.Test;
1616
import org.objectweb.asm.Opcodes;
1717
import org.testcontainers.containers.ComposeContainer;
18+
import org.testcontainers.containers.wait.strategy.Wait;
1819
import org.testcontainers.junit.jupiter.Container;
1920
import org.testcontainers.junit.jupiter.Testcontainers;
2021

@@ -36,13 +37,9 @@ public class Tomcat8WebSocketBypassNginxTest {
3637
@Container
3738
public static final ComposeContainer compose =
3839
new ComposeContainer(new File("docker-compose/tomcat/docker-compose-8-jre8-nginx.yaml"))
40+
.withExposedService("tomcat", 8080, Wait.forHttp("/app/"))
3941
.withExposedService("nginx", 80);
4042

41-
@AfterAll
42-
static void tearDown() {
43-
log.info(compose.getContainerByServiceName("tomcat").get().getLogs());
44-
}
45-
4643
public static String getUrl() {
4744
String host = compose.getServiceHost("nginx", 80);
4845
int port = compose.getServicePort("nginx", 80);

0 commit comments

Comments
 (0)