ReactVision
diff --git a/‎.github/actions/test-ios-helloworld/action.yml‎
Lines changed: 50 additions & 51 deletions b/‎.github/actions/test-ios-helloworld/action.yml‎
Lines changed: 50 additions & 51 deletions
diff --git a/‎.github/actions/test-ios-rntester/action.yml‎
Lines changed: 73 additions & 41 deletions b/‎.github/actions/test-ios-rntester/action.yml‎
Lines changed: 73 additions & 41 deletions
diff --git a/‎.github/actions/test-visionos-rntester/action.yml‎
Lines changed: 74 additions & 0 deletions b/‎.github/actions/test-visionos-rntester/action.yml‎
Lines changed: 74 additions & 0 deletions
@@ -1,90 +1,89 @@
 name: test-ios-helloworld
 description: Test iOS Hello World
 inputs:
+  jsengine:
+    description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
+    default: Hermes
   use-frameworks:
     description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
     default: StaticLibraries
+  architecture:
+    description: The React Native architecture to Test. RNTester has always Fabric enabled, but we want to run integration test with the old arch setup. Must be one of "OldArch" or "NewArch"
+    default: OldArch
   ruby-version:
     description: The version of ruby that must be used
     default: 2.6.10
   flavor:
     description: The flavor of the build. Must be one of "Debug", "Release".
     default: Debug
-  use-hermes-nightly:
-    description: Whether to override pinned Hermes versions with the latest nightly
-    required: false
-    default: 'true'
+  hermes-version:
+    description: The version of hermes
+    required: true
+  react-native-version:
+    description: The version of react-native
+    required: true
 runs:
   using: composite
   steps:
     - name: Setup xcode
       uses: ./.github/actions/setup-xcode
-      with:
-        platform: ios
     - name: Setup node.js
       uses: ./.github/actions/setup-node
-    - name: Run yarn install
-      uses: ./.github/actions/yarn-install
-    - name: Setup ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ inputs.ruby-version }}
-    - name: Set nightly Hermes versions
-      if: ${{ inputs.use-hermes-nightly == 'true' }}
+    - name: Create Hermes folder
       shell: bash
-      run: |
-        HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
-        if [ "$HERMES_VERSION" == "1000.0.0" ]; then
-          node ./scripts/releases/use-hermes-nightly.js
-        fi
-    - name: Run yarn install again, with the correct hermes version
-      if: ${{ inputs.use-hermes-nightly == 'true' }}
-      uses: ./.github/actions/yarn-install
-    - name: Download ReactNativeDependencies
-      if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
+      run: mkdir -p "$HERMES_WS_DIR"
+    - name: Download Hermes
       uses: actions/download-artifact@v4
       with:
-        name: ReactNativeDependencies${{ inputs.flavor }}.xcframework.tar.gz
-        path: /tmp/third-party
-    - name: Print third-party folder
-      if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
+        name: hermes-darwin-bin-${{ inputs.flavor }}
+        path: /tmp/hermes/hermes-runtime-darwin/
+    - name: Print Downloaded hermes
       shell: bash
-      run: ls -lR /tmp/third-party
-    - name: Download React Native Prebuilds
-      if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
-      uses: actions/download-artifact@v4
+      run: ls -lR "$HERMES_WS_DIR"
+    - name: Run yarn
+      uses: ./.github/actions/yarn-install
+    - name: Setup ruby
+      uses: ruby/setup-ruby@v1.171.0
       with:
-        name: ReactCore${{ inputs.flavor }}.xcframework.tar.gz
-        path: /tmp/ReactCore
-    - name: Print ReactCore folder
-      if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
-      shell: bash
-      run: ls -lR /tmp/ReactCore
-    - name: Install iOS dependencies - Configuration ${{ inputs.flavor }};
+        ruby-version: ${{ inputs.ruby-version }}
+    - name: Install iOS dependencies - Configuration ${{ inputs.flavor }}; New Architecture ${{ inputs.architecture }}; JS Engine ${{ inputs.jsengine }}
       shell: bash
       run: |
-        cd private/helloworld
+        cd packages/helloworld
         args=()
 
+        if [[ ${{ inputs.architecture }} == "OldArch" ]]; then
+          args+=(--arch old)
+        fi
+
         if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
           args+=(--frameworks dynamic)
-        else
-          export RCT_USE_LOCAL_RN_DEP="/tmp/third-party/ReactNativeDependencies${{ inputs.flavor }}.xcframework.tar.gz"
-          export RCT_TESTONLY_RNCORE_TARBALL_PATH="/tmp/ReactCore/ReactCore${{ inputs.flavor }}.xcframework.tar.gz"
         fi
 
-        yarn bootstrap ios "${args[@]}" | cat
+        if [[ ${{ inputs.jsengine }} == "JSC" ]]; then
+          args+=(--jsvm jsc)
+          yarn bootstrap ios "${args[@]}" | cat
+        else
+          # Tarball is restored with capital flavors suffix, but somehow the tarball name from JS at line 96 returns as lowercased.
+          # Let's ensure that the tarballs have the right names
 
-    - name: Run Helloworld tests
-      shell: bash
-      run: |
-        cd private/helloworld
-        yarn test
+          if [[ -f "$HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-Debug.tar.gz" ]]; then
+            mv "$HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-Debug.tar.gz" "$HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-debug.tar.gz"
+          fi
 
-    - name: Build HelloWorld project
+          if [[ -f "$HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-Release.tar.gz" ]]; then
+            mv "$HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-Release.tar.gz" "$HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-release.tar.gz"
+          fi
+
+          BUILD_TYPE="${{ inputs.flavor }}"
+          TARBALL_FILENAME=$(node ../react-native/scripts/hermes/get-tarball-name.js --buildType "$BUILD_TYPE")
+          HERMES_PATH="$HERMES_WS_DIR/hermes-runtime-darwin/$TARBALL_FILENAME"
+          HERMES_ENGINE_TARBALL_PATH="$HERMES_PATH" yarn bootstrap ios "${args[@]}" | cat
+        fi
+    - name: Build HelloWorld  project
       shell: bash
       run: |
-        cd private/helloworld
+        cd packages/helloworld
 
         args=()
         if [[ ${{ inputs.flavor }} == "Release" ]]; then
 
@@ -1,90 +1,122 @@
 name: test-ios-rntester
 description: Test iOS RNTester
 inputs:
+  jsengine:
+    description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
+    default: Hermes
   use-frameworks:
     description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
     default: StaticLibraries
+  architecture:
+    description: The React Native architecture to Test. RNTester has always Fabric enabled, but we want to run integration test with the old arch setup
+    default: NewArch
   ruby-version:
     description: The version of ruby that must be used
     default: 2.6.10
   run-unit-tests:
     description: whether unit tests should run or not.
     default: "false"
+  hermes-tarball-artifacts-dir:
+    description: The directory where the hermes tarball artifacts are stored
+    default: /tmp/hermes/hermes-runtime-darwin
   flavor:
     description: The flavor of the build. Must be one of "Debug", "Release".
     default: Debug
+  hermes-version:
+    description: The version of hermes
+    required: true
+  react-native-version:
+    description: The version of react-native
+    required: true
   run-e2e-tests:
     description: Whether we want to run E2E tests or not
     required: false
     default: false
-  use-hermes-nightly:
-    description: Whether to override pinned Hermes versions with the latest nightly
-    required: false
-    default: 'true'
 
 runs:
   using: composite
   steps:
     - name: Setup xcode
       uses: ./.github/actions/setup-xcode
-      with:
-        platform: ios
     - name: Setup node.js
       uses: ./.github/actions/setup-node
     - name: Run yarn
       uses: ./.github/actions/yarn-install
+    - name: Download Hermes
+      uses: actions/download-artifact@v4
+      with:
+        name: hermes-darwin-bin-${{ inputs.flavor }}
+        path: ${{ inputs.hermes-tarball-artifacts-dir }}
     - name: Setup ruby
-      uses: ruby/setup-ruby@v1
+      uses: ruby/setup-ruby@v1.171.0
       with:
         ruby-version: ${{ inputs.ruby-version }}
-    - name: Set nightly Hermes versions
-      if: ${{ inputs.use-hermes-nightly == 'true' }}
-      shell: bash
-      run: |
-        HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
-        if [ "$HERMES_VERSION" == "1000.0.0" ]; then
-          node ./scripts/releases/use-hermes-nightly.js
-        fi
-    - name: Run yarn install again, with the correct hermes version
-      if: ${{ inputs.use-hermes-nightly == 'true' }}
-      uses: ./.github/actions/yarn-install
     - name: Prepare IOS Tests
       if: ${{ inputs.run-unit-tests == 'true' }}
       uses: ./.github/actions/prepare-ios-tests
-    - name: Download ReactNativeDependencies
-      if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
-      uses: actions/download-artifact@v4
-      with:
-        name: ReactNativeDependencies${{ inputs.flavor }}.xcframework.tar.gz
-        path: /tmp/third-party/
-    - name: Print third-party folder
-      if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
+    - name: Set HERMES_ENGINE_TARBALL_PATH envvar if Hermes tarball is present
       shell: bash
-      run: ls -lR /tmp/third-party
-    - name: Download React Native Prebuilds
-      if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
-      uses: actions/download-artifact@v4
-      with:
-        name: ReactCore${{ inputs.flavor }}.xcframework.tar.gz
-        path: /tmp/ReactCore
-    - name: Print ReactCore folder
-      if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
+      run: |
+        HERMES_TARBALL_ARTIFACTS_DIR=${{ inputs.hermes-tarball-artifacts-dir }}
+        if [ ! -d $HERMES_TARBALL_ARTIFACTS_DIR ]; then
+          echo "Hermes tarball artifacts dir not present ($HERMES_TARBALL_ARTIFACTS_DIR). Build Hermes from source."
+          exit 0
+        fi
+
+        TARBALL_FILENAME=$(node ./packages/react-native/scripts/hermes/get-tarball-name.js --buildType "${{ inputs.flavor }}")
+        TARBALL_PATH=$HERMES_TARBALL_ARTIFACTS_DIR/$TARBALL_FILENAME
+
+        echo "Looking for $TARBALL_FILENAME in $HERMES_TARBALL_ARTIFACTS_DIR"
+        echo "$TARBALL_PATH"
+
+        if [ ! -f $TARBALL_PATH ]; then
+          echo "Hermes tarball not present ($TARBALL_PATH). Build Hermes from source."
+          exit 0
+        fi
+
+        echo "Found Hermes tarball at $TARBALL_PATH"
+        echo "HERMES_ENGINE_TARBALL_PATH=$TARBALL_PATH" >> $GITHUB_ENV
+    - name: Print Hermes version
       shell: bash
-      run: ls -lR /tmp/ReactCore
+      run: |
+        HERMES_TARBALL_ARTIFACTS_DIR=${{ inputs.hermes-tarball-artifacts-dir }}
+        TARBALL_FILENAME=$(node ./packages/react-native/scripts/hermes/get-tarball-name.js --buildType "${{ inputs.flavor }}")
+        TARBALL_PATH=$HERMES_TARBALL_ARTIFACTS_DIR/$TARBALL_FILENAME
+        if [[ -e $TARBALL_PATH ]]; then
+          tar -xf $TARBALL_PATH
+          echo 'print(HermesInternal?.getRuntimeProperties?.()["OSS Release Version"])' > test.js
+          chmod +x ./destroot/bin/hermes
+          ./destroot/bin/hermes test.js
+          rm test.js
+          rm -rf destroot
+        else
+          echo 'No Hermes tarball found.'
+        fi
+    - name: Setup xcode build cache
+      uses: ./.github/actions/setup-xcode-build-cache
+      with:
+        hermes-version: ${{ inputs.hermes-version }}
     - name: Install CocoaPods dependencies
       shell: bash
       run: |
+        if [[ ${{ inputs.jsengine }} == "JSC" ]]; then
+          export USE_HERMES=0
+        else
+          export HERMES_ENGINE_TARBALL_PATH=$HERMES_ENGINE_TARBALL_PATH
+        fi
+
         if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
           export USE_FRAMEWORKS=dynamic
-        else
-          export RCT_USE_LOCAL_RN_DEP="/tmp/third-party/ReactNativeDependencies${{ inputs.flavor }}.xcframework.tar.gz"
-          export RCT_TESTONLY_RNCORE_TARBALL_PATH="/tmp/ReactCore/ReactCore${{ inputs.flavor }}.xcframework.tar.gz"
+        fi
+
+        if [[ ${{ inputs.architecture }} == "OldArch" ]]; then
+          export RCT_NEW_ARCH_ENABLED=0
         fi
 
         cd packages/rn-tester
 
         bundle install
-        bundle exec pod update hermes-engine --no-repo-update
+        bundle exec pod install
     - name: Build RNTester
       shell: bash
       run: |
@@ -124,7 +156,7 @@ runs:
       if: ${{ inputs.use-frameworks == 'StaticLibraries' && inputs.ruby-version == '2.6.10' }} # This is needed to avoid conflicts with the artifacts
       uses: actions/upload-artifact@v4.3.4
       with:
-        name: RNTesterApp-NewArch-${{ inputs.flavor }}
+        name: RNTesterApp-${{ inputs.architecture }}-${{ inputs.jsengine }}-${{ inputs.flavor }}
         path: ${{ env.app-path }}
     - name: Store test results
       if: ${{ inputs.run-unit-tests == 'true' }}
 
@@ -0,0 +1,74 @@
+name: test-visionos-rntester
+description: Build visionOS RNTester using JSC
+inputs:
+  use-frameworks:
+    description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
+    default: StaticLibraries
+  architecture:
+    description: The React Native architecture to Test. RNTester has always Fabric enabled, but we want to run integration test with the old arch setup
+    default: NewArch
+  ruby-version:
+    description: The version of ruby that must be used
+    default: 2.6.10
+  flavor:
+    description: The flavor of the build. Must be one of "Debug", "Release".
+    default: Debug
+  react-native-version:
+    description: The version of react-native
+    required: true
+  run-e2e-tests:
+    description: Whether we want to run E2E tests or not
+    required: false
+    default: false
+
+runs:
+  using: composite
+  steps:
+    - name: Setup xcode
+      uses: ./.github/actions/setup-xcode
+      with:
+        xcode-version: "15.4"
+    - name: Setup node.js
+      uses: ./.github/actions/setup-node
+    - name: Run yarn
+      uses: ./.github/actions/yarn-install-with-cache
+    - name: Setup ruby
+      uses: ruby/setup-ruby@v1.171.0
+      with:
+        ruby-version: ${{ inputs.ruby-version }}
+    - name: Setup xcode build cache
+      uses: ./.github/actions/setup-xcode-build-cache
+    - name: Download visionOS SDK
+      run: |
+        # https://github.com/actions/runner-images/issues/10559
+        sudo xcodebuild -runFirstLaunch
+        sudo xcrun simctl list
+        sudo xcodebuild -downloadPlatform visionOS
+        sudo xcodebuild -runFirstLaunch
+      shell: bash
+    - name: Install CocoaPods dependencies
+      shell: bash
+      run: |
+        export USE_HERMES=0
+
+        if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
+          export USE_FRAMEWORKS=dynamic
+        fi
+
+        if [[ ${{ inputs.architecture }} == "NewArch" ]]; then
+          export RCT_NEW_ARCH_ENABLED=1
+        fi
+
+        cd packages/rn-tester
+
+        bundle install
+        bundle exec pod install
+    - name: Build RNTester for visionOS
+      if: ${{ inputs.run-e2e-tests == 'false' }}
+      shell: bash
+      run: |
+        xcodebuild build \
+          -workspace packages/rn-tester/RNTesterPods.xcworkspace \
+          -scheme RNTester-visionOS \
+          -sdk xrsimulator \
+          -destination "platform=visionOS Simulator,name=Apple Vision Pro"