WIP V2.54.1#316
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for specifying a custom ReactVision endpoint in both Android and iOS AR session configuration, and introduces a new API to fetch scene data from the ReactVision backend. The changes ensure that the endpoint is properly propagated through the JNI, C++, and Objective-C layers, and that the new
rvGetScenemethod is available on both platforms.ReactVision Endpoint Configuration Enhancements:
endpointparameter to the ReactVision configuration methods and constructors in both Android (setReactVisionConfig) and iOS, allowing clients to specify a custom backend endpoint for cloud anchor and geospatial services. This is now passed through the JNI, C++ (VROARSessionARCore,VROCloudAnchorProviderReactVision), and Objective-C layers. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]New Scene Fetching API:
rvGetScenemethod in theVROARSessioninterface and its Android (VROARSessionARCore) and iOS (VROARSessioniOS) implementations, enabling retrieval of scene data (as JSON) from the ReactVision backend. The method is exposed to Java (ARScene) and hooked up through JNI and C++ layers. [1] [2] [3] [4] [5] [6] [7] [8]These changes improve the flexibility and cloud integration capabilities of the AR platform, making it easier to configure and interact with the ReactVision backend.