Skip to content

Commit 5c082c3

Browse files
committed
Bump rotor barrier threshold to 60 kJ/mol; fix multi-well warning
The 40 kJ/mol default was too tight for combustion-temperature rotors; 60 kJ/mol better fits hindered-rotor treatment at kT ≈ 8–17 kJ/mol. Also rewrite the multi-well "high barrier" warning, which was missing a noun ("has 2," -> "has 2 wells") and read as a run-on.
1 parent a59862e commit 5c082c3

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

arc/job/trsh.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1715,13 +1715,12 @@ def scan_quality_check(label: str,
17151715
logger.warning(message)
17161716
return invalidate, invalidation_reason, message, actions
17171717
else:
1718-
logger.warning(f'The maximal barrier for rotor {pivots} of {label} is '
1719-
f'{(np.max(energies) - np.min(energies)):.2f} kJ/mol, which is higher than the set threshold '
1720-
f'of {maximum_barrier} kJ/mol. Since this mode when treated as torsion has {num_wells}, '
1721-
f'this mode is not invalidated: treating it as a vibrational mode will be less accurate than '
1722-
f'the hindered rotor treatment, since the entropy contribution from the population of '
1723-
f'this species at the higher wells will not be taken into account. NOT invalidating this '
1724-
f'torsional mode.')
1718+
barrier_kJmol = np.max(energies) - np.min(energies)
1719+
logger.warning(f'Rotor {pivots} of {label}: barrier {barrier_kJmol:.2f} kJ/mol '
1720+
f'exceeds the {maximum_barrier} kJ/mol threshold, but the mode has '
1721+
f'{num_wells} wells. Keeping the hindered-rotor treatment — '
1722+
f'demoting to a harmonic vibration would miss the entropic '
1723+
f'contribution from the upper well(s).')
17251724

17261725
if preserve_params is not None:
17271726
success = True

arc/settings/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,8 @@
265265
rotor_scan_resolution = 8.0 # degrees. Default: 8.0
266266

267267
# rotor validation parameters
268-
maximum_barrier = 40 # a rotor threshold (kJ/mol) above which the mode will be considered as vibrational if
269-
# there's only one well. Default: 40 (~10 kcal/mol)
268+
maximum_barrier = 60 # a rotor threshold (kJ/mol) above which the mode will be considered as vibrational if
269+
# there's only one well. Default: 60 (~14 kcal/mol)
270270
minimum_barrier = 1.0 # a rotor threshold (kJ/mol) below which it is considered a FreeRotor. Default: 1.0 kJ/mol
271271
inconsistency_az = 5 # maximum allowed inconsistency (kJ/mol) between initial and final rotor scan points. Default: 5
272272
inconsistency_ab = 0.3 # maximum allowed inconsistency between consecutive points in the scan given as a fraction

0 commit comments

Comments
 (0)