Skip to content

Commit c99d254

Browse files
committed
Refine DLPNO monoatomic logic and update CABS test coverage
Restricts the DLPNO incompatibility check in ORCA to single-electron species only, as heavier monoatomic species are supported. Additionally, updates the test suite to reflect the transition of the CABS basis from the auxiliary basis string to its own dedicated attribute.
1 parent 53aeb68 commit c99d254

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

arc/job/trsh.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,8 +1018,8 @@ def trsh_ess_job(label: str,
10181018
couldnt_trsh = True
10191019

10201020
elif 'orca' in software:
1021-
if 'dlpno' in level_of_theory.method and (is_monoatomic or is_h):
1022-
raise TrshError(f'DLPNO methods are incompatible with monoatomic species {label} in Orca. '
1021+
if 'dlpno' in level_of_theory.method and is_h:
1022+
raise TrshError(f'DLPNO methods are incompatible with single-electron species {label} in Orca. '
10231023
f'This should have been caught by the Scheduler before job submission.')
10241024
elif 'Memory' in job_status['keywords']:
10251025
# Increase memory allocation.

arc/main_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,14 +298,14 @@ def test_determine_model_chemistry_for_job_types(self):
298298
freq_level={'method': 'B3LYP/G', 'basis': 'cc-pVDZ(fi/sf/fw)', 'auxiliary_basis': 'def2-svp/C',
299299
'dispersion': 'DEF2-tzvp/c'},
300300
sp_level={'method': 'DLPNO-CCSD(T)-F12', 'basis': 'cc-pVTZ-F12',
301-
'auxiliary_basis': 'aug-cc-pVTZ/C cc-pVTZ-F12-CABS'},
301+
'auxiliary_basis': 'aug-cc-pVTZ/C', 'cabs': 'cc-pVTZ-F12-CABS'},
302302
calc_freq_factor=False, compute_thermo=False)
303303
self.assertEqual(arc9.opt_level.simple(), 'wb97xd/def2tzvp')
304304
self.assertEqual(str(arc9.freq_level), 'b3lyp/g/cc-pvdz(fi/sf/fw), auxiliary_basis: def2-svp/c, '
305305
'dispersion: def2-tzvp/c, software: gaussian')
306306
self.assertEqual(str(arc9.sp_level),
307-
'dlpno-ccsd(t)-f12/cc-pvtz-f12, auxiliary_basis: aug-cc-pvtz/c cc-pvtz-f12-cabs, '
308-
'software: orca')
307+
'dlpno-ccsd(t)-f12/cc-pvtz-f12, auxiliary_basis: aug-cc-pvtz/c, '
308+
'cabs: cc-pvtz-f12-cabs, software: orca')
309309

310310
# Test using default frequency and orbital level for composite job, also forbid rotors job
311311
arc10 = ARC(project='test', composite_method='cbs-qb3', calc_freq_factor=False,

0 commit comments

Comments
 (0)