Skip to content

Added a .index attr to ARCSpecies#808

Merged
ranbenayoun merged 2 commits intomainfrom
spc.index
Dec 31, 2025
Merged

Added a .index attr to ARCSpecies#808
ranbenayoun merged 2 commits intomainfrom
spc.index

Conversation

@alongd
Copy link
Copy Markdown
Member

@alongd alongd commented Dec 7, 2025

Used by T3 for migrating away from RMG Species() and into ARCSpecies()

Copy link
Copy Markdown
Contributor

@ranbenayoun ranbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should there be an adjustment in species_test.py to test it?

@alongd
Copy link
Copy Markdown
Member Author

alongd commented Dec 8, 2025

Thanks, I added a small test

Used by T3 for migrating away from RMG Species() and into ARCSpecies()
Copy link
Copy Markdown
Contributor

@ranbenayoun ranbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ranbenayoun ranbenayoun merged commit 9252a0d into main Dec 31, 2025
6 checks passed
@ranbenayoun ranbenayoun deleted the spc.index branch December 31, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants