-
Notifications
You must be signed in to change notification settings - Fork 24
Arkane matching method name #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
882d898
Add pyproject.toml for build system configuration
calvinp0 1727e60
Add year attribute to Level class and corresponding tests
calvinp0 52d522b
Add warning for year attribute on non-Arkane levels and corresponding…
calvinp0 a9ef231
Add pjrt_executable.cc to warning types in xTBAdapter - Kfir
calvinp0 398e541
Enhance ArkaneAdapter with year handling and related tests
calvinp0 00c843e
Update documentation to clarify year handling in arkane_level_of_theory
calvinp0 0db4191
Refactor project name handling in restart tests to avoid collisions i…
calvinp0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -406,6 +406,7 @@ def __init__(self, | |
| self.job_types['opt'] = True # Run the optimizations, self.fine_only will make sure that they are fine. | ||
|
|
||
| self.set_levels_of_theory() # All level of theories should be Level types after this call. | ||
| self._warn_year_on_non_arkane_levels() | ||
| if self.thermo_adapter == 'arkane': | ||
| self.check_arkane_level_of_theory() | ||
|
|
||
|
|
@@ -1155,6 +1156,17 @@ def process_level_of_theory(self): | |
|
|
||
| self.level_of_theory = '' # Reset the level_of_theory argument to avoid conflicts upon restarting ARC. | ||
|
|
||
| def _warn_year_on_non_arkane_levels(self): | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you implement this in level.py, and call it here? just so we store level-related-things at one place |
||
| """ | ||
| Warn if ``year`` was specified on any Level other than ``arkane_level_of_theory``. | ||
| The ``year`` attribute only affects Arkane database matching and is ignored elsewhere. | ||
| """ | ||
| for attr_name in ('sp_level', 'opt_level', 'freq_level', 'scan_level', 'irc_level', | ||
| 'conformer_opt_level', 'conformer_sp_level', 'orbitals_level'): | ||
| level = getattr(self, attr_name, None) | ||
| if isinstance(level, Level): | ||
| level.warn_if_year_set(attr_name) | ||
|
|
||
| def check_arkane_level_of_theory(self): | ||
| """ | ||
| Check that the level of theory has AEC in Arkane. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why limit ARC just up to 9999 AD? :)