Skip to content

Improved the xTB parser#856

Merged
LeenFahoum merged 4 commits intomainfrom
xTB
Apr 12, 2026
Merged

Improved the xTB parser#856
LeenFahoum merged 4 commits intomainfrom
xTB

Conversation

@alongd
Copy link
Copy Markdown
Member

@alongd alongd commented Apr 7, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves ARC’s xTB parsing behavior and strengthens regression coverage for common xTB log output edge cases.

Changes:

  • Fix xTB 1D scan angle generation so returned angles and energies lengths match.
  • Improve xTB parsing robustness for frequencies (use last eigval block), ZPE parsing (regex), energy parsing (avoid “total energy gain” false match), geometry parsing (reset on new blocks), and basic error detection.
  • Add targeted unit tests covering the above xTB-specific behaviors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
arc/parser/parser_test.py Updates 1D scan expectations and adds xTB-focused regression tests for energy/frequency/ZPE/geometry/error detection.
arc/parser/adapters/xtb.py Implements xTB parser robustness improvements (error detection, geometry block reset, eigval-block selection, regex parsing, angle-length fix).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread arc/parser/adapters/xtb.py Outdated
Comment thread arc/parser/adapters/xtb.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.09%. Comparing base (5c50f88) to head (960197e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
+ Coverage   60.08%   60.09%   +0.01%     
==========================================
  Files         102      102              
  Lines       31041    31045       +4     
  Branches     8082     8087       +5     
==========================================
+ Hits        18651    18658       +7     
+ Misses      10076    10071       -5     
- Partials     2314     2316       +2     
Flag Coverage Δ
functionaltests 60.09% <ø> (+0.01%) ⬆️
unittests 60.09% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alongd alongd requested a review from LeenFahoum April 7, 2026 10:46
@alongd alongd force-pushed the xTB branch 4 times, most recently from 7753fd4 to 3a846d3 Compare April 9, 2026 19:15
@LeenFahoum LeenFahoum merged commit 32a8ea1 into main Apr 12, 2026
8 checks passed
@LeenFahoum LeenFahoum deleted the xTB branch April 12, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants