-
Notifications
You must be signed in to change notification settings - Fork 24
Migrating ARC to Python 14 #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
32a0b2e
Bump Python to 3.14, Cython >=3.1, RDKit >=2026.03
alongd 109bacf
Tests: proper teardown of molpro tests
alongd 4e8d44e
Modernize typing imports for Python 3.14+
alongd 6fbc0d6
Fix gh-pages workflow for Python 3.14
alongd a7fa92e
Update test assertions for Python 3.14 compatibility
alongd 4918ee4
Update docs and badges for Python 3.14
alongd 8ddb8ff
Use tempdir for tests to avoid race condition between test workers
alongd b3d1061
Auto-detect BABEL_LIBDIR/BABEL_DATADIR in settings.py
alongd e05c567
Fix pre-existing CodeQL warnings
alongd dd6bf29
Clone current branch for docker
alongd 2669734
Replace py-rdl install script with danagroup conda package
alongd 80cd5e7
Fix pipe worker OpenBabel failure by injecting LD_LIBRARY_PATH
alongd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,7 @@ examples/ | |
|
|
||
| # Unit test files | ||
| .coverage | ||
| .coverage.* | ||
| testing/* | ||
| htmlcov/* | ||
| arc/testing/gcn_tst/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to be set in
maintoo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the gh-pages workflow creates rmg_env first, which sets a condarc with only conda-forge. Without the explicit condarc on the
arc_envstep, the danagroup channel gets lost and openbabel can't be resolved for Py 3.14. CI doesn't need it because it only creates one env.