Skip to content

Break down monolithic driver and heuristics tests#881

Merged
alongd merged 2 commits into
mainfrom
brk_tsts
Apr 28, 2026
Merged

Break down monolithic driver and heuristics tests#881
alongd merged 2 commits into
mainfrom
brk_tsts

Conversation

@alongd
Copy link
Copy Markdown
Member

@alongd alongd commented Apr 27, 2026

Splits the catch-all test_map_abstractions and heuristics tests into one test per reaction case, so failures point at a specific scenario instead of one giant test. Shared XYZ fixtures live on setUpClass. No production-code changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.45%. Comparing base (0f5d3ad) to head (5fe55b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   60.44%   60.45%           
=======================================
  Files         102      102           
  Lines       31096    31096           
  Branches     8103     8103           
=======================================
+ Hits        18796    18798    +2     
+ Misses       9957     9956    -1     
+ Partials     2343     2342    -1     
Flag Coverage Δ
functionaltests 60.45% <ø> (+<0.01%) ⬆️
unittests 60.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors ARC’s unit tests to improve failure granularity by splitting previously monolithic mapping-driver and heuristics tests into smaller, scenario-specific test cases. This makes it easier to identify which specific reaction case/regression is responsible when a test fails, without changing production behavior.

Changes:

  • Split test_map_abstractions into multiple focused test methods, with shared XYZ fixtures moved to setUpClass.
  • Split combined hydrolysis heuristics coverage into three dedicated tests (carbonyl-based, ether, nitrile), using separate per-test project directories.
  • Refactor are_h_abs_wells_reversed coverage into multiple targeted tests using a shared assertion helper; expand teardown cleanup to remove the new test directories.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
arc/mapping/driver_test.py Breaks up mapping abstraction cases into individual tests and centralizes shared XYZ fixtures in setUpClass.
arc/job/adapters/ts/heuristics_test.py Splits hydrolysis heuristics tests by family, refactors H-abstraction well-orientation assertions into a helper + per-scenario tests, and updates teardown cleanup for new directories.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alongd alongd requested a review from ranbenayoun April 27, 2026 16:53
alongd added 2 commits April 28, 2026 14:13
So that they can be ran independently by different CI workers
So that they can be ran independently by different CI workers
Copy link
Copy Markdown
Contributor

@ranbenayoun ranbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@alongd alongd merged commit 23bf4ae into main Apr 28, 2026
6 checks passed
@alongd alongd deleted the brk_tsts branch April 28, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants