Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 60.44% 60.45%
=======================================
Files 102 102
Lines 31096 31096
Branches 8103 8103
=======================================
+ Hits 18796 18798 +2
+ Misses 9957 9956 -1
+ Partials 2343 2342 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR refactors ARC’s unit tests to improve failure granularity by splitting previously monolithic mapping-driver and heuristics tests into smaller, scenario-specific test cases. This makes it easier to identify which specific reaction case/regression is responsible when a test fails, without changing production behavior.
Changes:
- Split
test_map_abstractionsinto multiple focused test methods, with shared XYZ fixtures moved tosetUpClass. - Split combined hydrolysis heuristics coverage into three dedicated tests (carbonyl-based, ether, nitrile), using separate per-test project directories.
- Refactor
are_h_abs_wells_reversedcoverage into multiple targeted tests using a shared assertion helper; expand teardown cleanup to remove the new test directories.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
arc/mapping/driver_test.py |
Breaks up mapping abstraction cases into individual tests and centralizes shared XYZ fixtures in setUpClass. |
arc/job/adapters/ts/heuristics_test.py |
Splits hydrolysis heuristics tests by family, refactors H-abstraction well-orientation assertions into a helper + per-scenario tests, and updates teardown cleanup for new directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
So that they can be ran independently by different CI workers
So that they can be ran independently by different CI workers
Splits the catch-all
test_map_abstractionsand heuristics tests into one test per reaction case, so failures point at a specific scenario instead of one giant test. Shared XYZ fixtures live onsetUpClass. No production-code changes.