Skip to content

Commit 3765e6d

Browse files
Updating tunneling to allow calculations for symmetric Eckart
Allowing for symmetric eckart tunneling. In symmetric eckart we assume the reactants and product have the same energy, therefore the terms dV1 = E0_TS - E0_reac dV2 = E0_TS - E0_prod will be equal. To allow for this I have relaxed the assertion dV1 < dV2 to dV1 <= dV2. It works fine for my test reactions. I would assume the assertion was originally placed anticipating so as not to run into a numerical issue (division by 0).
1 parent aa8b53a commit 3765e6d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

rmgpy/kinetics/tunneling.pyx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ cdef class Eckart(TunnelingModel):
175175
raise ValueError('One or both of the barrier heights of {0:g} and {1:g} kJ/mol encountered in Eckart method are invalid.'.format(dV1 / 1000., dV2 / 1000.))
176176

177177
# Ensure that dV1 is smaller than dV2
178-
assert dV1 < dV2
178+
assert dV1 <= dV2
179179

180180
# Evaluate microcanonical tunneling function kappa(E)
181181
dE = 100.
@@ -218,7 +218,7 @@ cdef class Eckart(TunnelingModel):
218218
dV2 = E0_TS - E0_reac
219219

220220
# Ensure that dV1 is smaller than dV2
221-
assert dV1 < dV2
221+
assert dV1 <= dV2
222222

223223
alpha1 = 2 * constants.pi * dV1 / frequency
224224
alpha2 = 2 * constants.pi * dV2 / frequency

0 commit comments

Comments
 (0)