Skip to content

Commit 731b402

Browse files
authored
Merge pull request #2941 to tweak SIDT tree generation
iter_item_cap now passed to make_tree_nodes even if cascade algorithm isn't used tree generation was taking forever because grp.get_extensions has found bond formation extensions that match all the training reactions in the node and are flagged to be further expanded, which explodes the amount of extensions to be evaluated. I see that this issue was addressed in commit b6ae40d, where an iter_item cap will force it to give up the split if it runs into this issue but only when the cascade algorithm is used.
2 parents b192132 + 6454ef8 commit 731b402

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

rmgpy/data/kinetics/family.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3294,7 +3294,7 @@ def generate_tree(self, rxns=None, obj=None, thermo_database=None, T=1000.0, npr
32943294
template_rxn_map = self.get_reaction_matches(rxns=rxns, thermo_database=thermo_database, remove_degeneracy=True,
32953295
fix_labels=True, exact_matches_only=True, get_reverse=True)
32963296
self.make_tree_nodes(template_rxn_map=template_rxn_map, obj=obj, T=T, nprocs=nprocs - 1, depth=0,
3297-
min_splitable_entry_num=min_splitable_entry_num, min_rxns_to_spawn=min_rxns_to_spawn,extension_iter_max=extension_iter_max)
3297+
min_splitable_entry_num=min_splitable_entry_num, min_rxns_to_spawn=min_rxns_to_spawn,extension_iter_max=extension_iter_max, extension_iter_item_cap=extension_iter_item_cap)
32983298
else:
32993299
def rxnkey(rxn):
33003300
c = 0

0 commit comments

Comments
 (0)