Skip to content

Commit 80b13d9

Browse files
mjohnson541ssun30
authored andcommitted
alllow Marcus kinetics in families
1 parent 22f6556 commit 80b13d9

1 file changed

Lines changed: 20 additions & 2 deletions

File tree

rmgpy/data/kinetics/family.py

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
ForbiddenStructureException, UndeterminableKineticsError
5757
from rmgpy.kinetics import Arrhenius, SurfaceArrhenius, SurfaceArrheniusBEP, StickingCoefficient, \
5858
StickingCoefficientBEP, ArrheniusBM, SurfaceChargeTransfer, ArrheniusChargeTransfer, \
59-
ArrheniusChargeTransferBM, KineticsModel
59+
ArrheniusChargeTransferBM, KineticsModel, Marcus
6060
from rmgpy.kinetics.uncertainties import RateUncertainty, rank_accuracy_map
6161
from rmgpy.molecule import Bond, GroupBond, Group, Molecule
6262
from rmgpy.molecule.atomtype import ATOMTYPES
@@ -3547,7 +3547,25 @@ def make_bm_rules_from_template_rxn_map(self, template_rxn_map, nprocs=1, Tref=1
35473547
kinetics_list = kinetics_list[revinds] # fix order
35483548

35493549
for i, kinetics in enumerate(kinetics_list):
3550-
if kinetics is not None:
3550+
if isinstance(kinetics, Marcus):
3551+
entry = entries[i]
3552+
st = "Marcus rule fitted to {0} training reactions at node {1}".format(len(rxnlists[i][0]), entry.label)
3553+
new_entry = Entry(
3554+
index=index,
3555+
label=entry.label,
3556+
item=self.forward_template,
3557+
data=kinetics,
3558+
rank=11,
3559+
reference=None,
3560+
short_desc=st,
3561+
long_desc=st,
3562+
)
3563+
new_entry.data.comment = st
3564+
3565+
self.rules.entries[entry.label].append(new_entry)
3566+
3567+
index += 1
3568+
elif kinetics is not None:
35513569
entry = entries[i]
35523570
std = kinetics.uncertainty.get_expected_log_uncertainty() / 0.398 # expected uncertainty is std * 0.398
35533571
st = "BM rule fitted to {0} training reactions at node {1}".format(len(rxnlists[i][0]), entry.label)

0 commit comments

Comments
 (0)