Merge pull request #2824 from ReactionMechanismGenerator/fix/examples

Fix broken examples

Author: BonhyeokKoo

examples/rmg/MR_test/input.py

@@ -275,8 +275,8 @@
  	minimumNumberOfGrains=250,
  	#the conditions for the rate to be output over
  	#parameter order is: low_value, high_value, units, internal points
- 	temperatures=(300,2200,'K',2),
- 	pressures=(0.01,100.01,'bar',3),
+ 	temperatures=(300,2200,'K',10),
+ 	pressures=(0.01,100.01,'bar',10),
  	#The two options for interpolation are 'PDepArrhenius' (no extra arguments) and 
  	#'Chebyshev' which is followed by the number of basis sets in 
  	#Temperature and Pressure. These values must be less than the number of 

examples/rmg/TEOS/input.py

@@ -4,7 +4,7 @@
 	reactionLibraries = [],
 	seedMechanisms = [],
 	kineticsDepositories = ['training'],
-	kineticsFamilies = ['!Intra_Disproportionation','!Substitution_O'],
+	kineticsFamilies = ['!Intra_Disproportionation','!Substitution_O', '!surface'],
 	kineticsEstimator = 'rate rules',
 )
 

examples/rmg/catalysis/methane_steam/input.py

@@ -1,7 +1,7 @@
 # Data sources
 database(
     thermoLibraries=['surfaceThermoNi111', 'surfaceThermoPt111', 'primaryThermoLibrary', 'thermo_DFT_CCSDTF12_BAC'], 
-    reactionLibraries = [('Surface/Deutschmann_Ni', True)], # when Pt is used change the library to Surface/CPOX_Pt/Deutschmann2006
+    reactionLibraries = [('Surface/Methane/Deutschmann_Ni', True)], # when Pt is used change the library to Surface/CPOX_Pt/Deutschmann2006
     seedMechanisms = [],
     kineticsDepositories = ['training'],
     kineticsFamilies = ['surface','default'],

examples/rmg/commented/input.py

@@ -250,8 +250,8 @@
     minimumNumberOfGrains=250,
     # the conditions for the rate to be output over
     # parameter order is: low_value, high_value, units, internal points
-    temperatures=(300, 2200, 'K', 2),
-    pressures=(0.01, 100, 'bar', 3),
+    temperatures=(300, 2200, 'K', 10),
+    pressures=(0.01, 100, 'bar', 10),
     # The two options for interpolation are 'PDepArrhenius' (no extra arguments) and
     # 'Chebyshev' which is followed by the number of basis sets in
     # Temperature and Pressure. These values must be less than the number of

examples/rmg/e85/input.py

@@ -4,7 +4,7 @@
     reactionLibraries = [],
     seedMechanisms = ['GRI-Mech3.0'],
     kineticsDepositories = ['training'],
-    kineticsFamilies = ['!Intra_Disproportionation','!Substitution_O'],
+    kineticsFamilies = ['!Intra_Disproportionation','!Substitution_O', '!surface'],
     kineticsEstimator = 'rate rules',
 )
 

examples/rmg/gri_mech_rxn_lib/input.py

@@ -40,6 +40,10 @@
     maximumEdgeSpecies=100000
 )
 
+generatedSpeciesConstraints(
+    maximumCarbeneRadicals=2,
+)
+
 options(
     units='si',
     generateOutputHTML=False,

examples/rmg/methylformate/input.py

@@ -4,7 +4,7 @@
     reactionLibraries = [('Methylformate',False),('Glarborg/highP',False)],
     seedMechanisms = ['Glarborg/C2'],
     kineticsDepositories = ['training'],
-    kineticsFamilies = ['!Intra_Disproportionation','!Substitution_O'],
+    kineticsFamilies = ['!Intra_Disproportionation','!Substitution_O', '!surface'],
     kineticsEstimator = 'rate rules',
 )
 

examples/rmg/minimal_sensitivity/input.py

@@ -4,7 +4,7 @@
     reactionLibraries = [],
     seedMechanisms = [],
     kineticsDepositories = ['training'],
-    kineticsFamilies = ['!Intra_Disproportionation','!Substitution_O'],
+    kineticsFamilies = ['!Intra_Disproportionation','!Substitution_O', '!surface'],
     kineticsEstimator = 'rate rules',
 )
 

examples/rmg/nox_transitory_edge/input.py

@@ -12,10 +12,12 @@
     reactive=True,	
     structure=SMILES("CC"),
 )
+
 species(
     label='O2',
     structure=SMILES("[O][O]"),
 )
+
 species(
     label='N2',
     reactive=False,
@@ -76,6 +78,7 @@
 
 generatedSpeciesConstraints(
     allowed=['input species','seed mechanisms','reaction libraries'],
+    allowSingletO2=True,
     #maximumCarbonAtoms=5,
     #maximumOxygenAtoms=8,
     #maximumNitrogenAtoms=0,

rmgpy/constraints.py

@@ -61,7 +61,8 @@ def pass_cutting_threshold(species):
 def fails_species_constraints(species):
     """
     Pass in either a `Species` or `Molecule` object and checks whether it passes 
-    the speciesConstraints set by the user.  If not, returns `True` for failing speciesConstraints.
+    the speciesConstraints set by the user.  If the species fails constraints, returns 
+    a string `reason` describing which constraint failed. If all constraints pass, returns `False`.
     """
 
     from rmgpy.rmg.input import get_input
@@ -86,57 +87,58 @@ def fails_species_constraints(species):
     max_carbon_atoms = species_constraints.get('maximumCarbonAtoms', -1)
     if max_carbon_atoms != -1:
         if struct.get_num_atoms('C') > max_carbon_atoms:
-            return True
+            return f"Exceeded maximumCarbonAtoms: {struct.get_num_atoms('C')} > {max_carbon_atoms}"
 
     max_oxygen_atoms = species_constraints.get('maximumOxygenAtoms', -1)
     if max_oxygen_atoms != -1:
         if struct.get_num_atoms('O') > max_oxygen_atoms:
-            return True
+            return f"Exceeded maximumOxygenAtoms: {struct.get_num_atoms('O')} > {max_oxygen_atoms}"
 
     max_nitrogen_atoms = species_constraints.get('maximumNitrogenAtoms', -1)
     if max_nitrogen_atoms != -1:
         if struct.get_num_atoms('N') > max_nitrogen_atoms:
-            return True
+            return f"Exceeded maximumNitrogenAtoms: {struct.get_num_atoms('N')} > {max_nitrogen_atoms}"
 
     max_silicon_atoms = species_constraints.get('maximumSiliconAtoms', -1)
     if max_silicon_atoms != -1:
         if struct.get_num_atoms('Si') > max_silicon_atoms:
-            return True
+            return f"Exceeded maximumSiliconAtoms: {struct.get_num_atoms('Si')} > {max_silicon_atoms}"
 
     max_sulfur_atoms = species_constraints.get('maximumSulfurAtoms', -1)
     if max_sulfur_atoms != -1:
         if struct.get_num_atoms('S') > max_sulfur_atoms:
-            return True
+            return f"Exceeded maximumSulfurAtoms: {struct.get_num_atoms('S')} > {max_sulfur_atoms}"
 
     max_heavy_atoms = species_constraints.get('maximumHeavyAtoms', -1)
     if max_heavy_atoms != -1:
-        if struct.get_num_atoms() - struct.get_num_atoms('H') > max_heavy_atoms:
-            return True
+        heavy_atoms = struct.get_num_atoms() - struct.get_num_atoms('H')
+        if heavy_atoms > max_heavy_atoms:
+            return f"Exceeded maximumHeavyAtoms: {heavy_atoms} > {max_heavy_atoms}"
 
     max_surface_sites = species_constraints.get('maximumSurfaceSites', -1)
     if max_surface_sites != -1:
         if struct.get_num_atoms('X') > max_surface_sites:
-            return True
+            return f"Exceeded maximumSurfaceSites: {struct.get_num_atoms('X')} > {max_surface_sites}"
 
     max_surface_bond_order = species_constraints.get('maximumSurfaceBondOrder', -1)
     if max_surface_bond_order != -1:
         for site in struct.get_surface_sites():
             if site.get_total_bond_order() > max_surface_bond_order:
-                return True
+                return f"Exceeded maximumSurfaceBondOrder at site: {site.get_total_bond_order()} > {max_surface_bond_order}"
 
     max_radicals = species_constraints.get('maximumRadicalElectrons', -1)
     if max_radicals != -1:
         if struct.get_radical_count() > max_radicals:
-            return True
+            return f"Exceeded maximumRadicalElectrons: {struct.get_radical_count()} > {max_radicals}"
 
     max_carbenes = species_constraints.get('maximumSingletCarbenes', 1)
-    if max_radicals != -1:
+    if max_carbenes != -1:
         if struct.get_singlet_carbene_count() > max_carbenes:
-            return True
+            return f"Exceeded maximumSingletCarbenes: {struct.get_singlet_carbene_count()} > {max_carbenes}"
 
     max_carbene_radicals = species_constraints.get('maximumCarbeneRadicals', 0)
     if max_carbene_radicals != -1:
         if struct.get_singlet_carbene_count() > 0 and struct.get_radical_count() > max_carbene_radicals:
-            return True
+            return f"Exceeded maximumCarbeneRadicals: {struct.get_radical_count()} > {max_carbene_radicals}"
 
     return False