quick fix to allow vapor liquid interface to accept T as function#241
Draft
donerancl wants to merge 2 commits intoReactionMechanismGenerator:mainfrom
Draft
quick fix to allow vapor liquid interface to accept T as function#241donerancl wants to merge 2 commits intoReactionMechanismGenerator:mainfrom
donerancl wants to merge 2 commits intoReactionMechanismGenerator:mainfrom
Conversation
…to accept T as a function
Author
|
now VaporLiquidMassTransferInternalInterfaceConstantT expects only functions for T, I will add a type check |
added check if T is a function for LiquidVaporTransferInternalInterfaceConstantT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VaporLiquidMassTransferInternalInterfaceConstantT raises an error when T is passed as a function of time because the construction of the kLA and kH arrays expects T to be a constant. @hwpang helped me to call the function for T when the kLA/kH arrays are constructed. Improvements could me made so that the arrays are not constructed every time the Interface is evaluated, but this works for now.