Open
Conversation
…ge dependence in particular this makes it so you can stick the coverage dependence on NASA and it will get passed down to its NASAPolynomial sub objects
in particular this adjust the dispatching to help handle the fact that coverage dependence complicates automatic differentiation
When we put information in the mechanism file we don't yet know the index associated with the species coverage dependence is with respect to this fills in the index (as opposed to species name) dictionaries on the coverage dependence objects so they are ready for efficient evaluation
…verage dependence
also ensures gibbs free energy is output (before an empty vector was returned if it was not expected to be needed, but coverage dependence makes us needed at the interface even for domains where Gs is constant)
also fixed bug related to handling of cpdivR in output from calcthermo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables coverage dependence for reactions on surfaces or interfaces with surfaces.