Conversation
…lculations fix variable naming fix a typo
(typo fixed during rebase)
Removed an invalid field in a Marcus type reaction in ORR.rms Fixed array input format in ORR.rms
`cat` is a default Julia function for concatenating arrays. As a precaution these are renamed to `catalyst` to avoid conflicts
this interface creates diffusive fluxes between a given domain and a constant concentration reservoir Some bugfixes by Su: Fixed undefined variable S Added missing "export" for ConstantReservoirDiffusion Co-authored-by: Matt Johnson <mjohnson541@gmail.com> Co-authored-by: Su Sun <sun.su@northeastern.edu>
fixup: fix assignment to dot addition .+=
Open
See ReactionMechanismGenerator/RMG-Py#2861 In version 0.9.29 of PythonCall they dropped support for verion 2.9 of Python, which we currently need for_rmg.
at different time points
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch was
constant_reservoir_diffusionwhen it was built on top of the oldfor_rmg. I have rebased it onto the latestmainand taken what care I could to resolve conflicts and remove redundancies appropriately. I have also then done a few iterations of interactive rebasing, to squash fixup commits, correct typos when they first happened, etc. So the commits won't look exactly like they used to, but should be a bit cleaner.While rebasing I dropped the commits that were just fiddling with the CI, presuming that the CI on
mainis correct.I think this incorporates everything in #247 (Marcus Kinetics) and #265, and probably #264.