Skip to content

set global seed for reproducibility#80

Merged
Nimrais merged 1 commit into
mainfrom
fix-kldivergence-rng
Nov 4, 2025
Merged

set global seed for reproducibility#80
Nimrais merged 1 commit into
mainfrom
fix-kldivergence-rng

Conversation

@bvdmitri
Copy link
Copy Markdown
Member

@bvdmitri bvdmitri commented Nov 4, 2025

Similar to ReactiveBayes/ExponentialFamilyManifolds.jl#43 but we have kldivergence in way more places, where we don't have access to StableRNG. Instead I attempt to set the seed once globally before running the tests, hoping they run in the same order every time.... at the very least its not bad to set the seed before running the tests

@bvdmitri bvdmitri requested a review from Nimrais November 4, 2025 19:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (9dc13e6) to head (24653b1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          12       12           
  Lines         486      486           
=======================================
  Hits          483      483           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Nimrais
Copy link
Copy Markdown
Member

Nimrais commented Nov 4, 2025

@bvdmitri What should we do with failed test dependencies?

@Nimrais Nimrais merged commit 56f0a73 into main Nov 4, 2025
6 of 8 checks passed
@Nimrais Nimrais deleted the fix-kldivergence-rng branch November 4, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants