Merge pull request #539 from ReactiveBayes/improving-codecov

Improving codecov

Author: bvdmitri

src/rules/gamma_mixture/a.jl

@@ -1,4 +1,3 @@
-
 @rule GammaMixture((:a, k), Marginalisation) (q_out::Any, q_switch::Any, q_b::GammaDistributionsFamily) = begin
     p = probvec(q_switch)[k]
     β = mean(log, q_out) + mean(log, q_b)

src/rules/gamma_mixture/out.jl

@@ -1,4 +1,3 @@
-
 @rule GammaMixture{N}(:out, Marginalisation) (q_switch::Any, q_a::ManyOf{N, Any}, q_b::ManyOf{N, GammaDistributionsFamily}) where {N} = begin
     πs = probvec(q_switch)
     return GammaShapeRate(sum(πs .* mean.(q_a)), sum(πs .* mean.(q_b)))

src/rules/gamma_mixture/switch.jl

@@ -1,4 +1,3 @@
-
 @rule GammaMixture{N}(:switch, Marginalisation) (q_out::Any, q_a::ManyOf{N, Any}, q_b::ManyOf{N, GammaDistributionsFamily}) where {N} = begin
     U = map(zip(q_a, q_b)) do (a, b)
         -score(AverageEnergy(), GammaShapeRate, Val{(:out, :α, :β)}(), map((q) -> Marginal(q, false, false, nothing), (q_out, a, b)), nothing)

test/nodes/predefined/autoregressive_tests.jl

@@ -53,4 +53,66 @@
             @test cmatrix == (matrix + ftransition)
         end
     end
+
+    # TODO: multivariate case coverage
+
+end
+
+@testitem "AutoregressiveNode: is_univariate, is_safe, is_unsafe, default_meta, is_multivariate cases, ar_unit, ARPrecisionMatrix" begin
+    using ReactiveMP, Distributions, ExponentialFamily, LazyArrays, LinearAlgebra, Test
+    import ReactiveMP: ARMeta, ARsafe, ARunsafe, AR, ar_unit, ar_precision, ARPrecisionMatrix
+    @testset "ARMeta and ARPrecisionMatrix extensions" begin
+
+        # --- ARMeta property tests ---
+        meta_uni = ARMeta(Univariate, 1, ARsafe())
+        meta_multi = ARMeta(Multivariate, 3, ARunsafe())
+
+        @test ReactiveMP.is_univariate(meta_uni)
+        @test !ReactiveMP.is_multivariate(meta_uni)
+        @test ReactiveMP.is_safe(meta_uni)
+        @test !ReactiveMP.is_unsafe(meta_uni)
+
+        @test ReactiveMP.is_multivariate(meta_multi)
+        @test !ReactiveMP.is_univariate(meta_multi)
+        @test ReactiveMP.is_unsafe(meta_multi)
+        @test !ReactiveMP.is_safe(meta_multi)
+
+        # --- default_meta should throw ---
+        @test_throws ErrorException ReactiveMP.default_meta(AR)
+
+        # --- ar_unit coverage ---
+        @test ar_unit(Univariate, 1) == 1.0
+        @test ar_unit(Multivariate, 3)[1] ≈ 1.0
+        @test eltype(ar_unit(Float32, Univariate, 1)) === Float32
+
+        # --- ar_precision and ARPrecisionMatrix ---
+        γ = 2.5
+        order = 3
+        pm = ar_precision(Multivariate, order, γ)
+        @test size(pm) == (3, 3)
+        @test pm[1, 1] == γ
+        @test pm[2, 2] ≈ convert(Float64, huge)
+        @test pm[1, 2] == 0.0
+
+        # add_precision & add_precision!
+        A = zeros(3, 3)
+        B = copy(A)
+        res = ReactiveMP.add_precision(A, pm)
+        @test res[1, 1] == γ
+        @test res[2, 2] ≈ huge
+
+        ReactiveMP.add_precision!(B, pm)
+        @test B[1, 1] == γ
+        @test B[3, 3] ≈ huge
+
+        # Real + Real overloads
+        @test ReactiveMP.add_precision!(1.0, 2.0) == 3.0
+        @test ReactiveMP.add_precision(1.0, 2.0) == 3.0
+
+        # Broadcast! directly
+        C = zeros(3, 3)
+        broadcast!(+, C, pm)
+        @test C[1, 1] == γ
+        @test all(diag(C)[2:end] .≈ huge)
+    end
 end

test/nodes/predefined/bifm_tests.jl

@@ -0,0 +1,70 @@
+@testitem "BIFM Node" begin
+    using ReactiveMP, Distributions, LinearAlgebra, Random, Test
+    import ReactiveMP:
+        getA, getB, getC, getH, getμu, getΣu, default_meta, setH!, setBHBt!, setξz!, setΛz!, setξztilde!, setΛztilde!, setμu!, setΣu!, getBHBt, getξz, getΛz, getξztilde, getΛztilde
+
+    @testset "BIFMMeta constructors" begin
+        A = [1.0 0.1; 0.0 1.0]
+        B = [0.5 0.0; 0.0 0.5]
+        C = [1.0 0.0; 0.0 1.0]
+
+        meta1 = BIFMMeta(A, B, C)
+        @test meta1 isa BIFMMeta{Float64}
+        @test getA(meta1) === A
+        @test getB(meta1) === B
+        @test getC(meta1) === C
+        @test getH(meta1) === nothing
+        @test getμu(meta1) === nothing
+
+        # test dimension checks
+        @test_throws AssertionError BIFMMeta(ones(2, 2), ones(3, 2), ones(2, 2))
+
+        # constructor with input priors
+        μu = randn(2)
+        Σu = diageye(2)
+        meta2 = BIFMMeta(A, B, C, μu, Σu)
+        @test getμu(meta2) == μu
+        @test getΣu(meta2) == Σu
+        @test meta2 isa BIFMMeta{Float64}
+    end
+
+    @testset "BIFMMeta setters and getters" begin
+        A = [1.0 0.0; 0.0 1.0]
+        B = [0.2 0.3; 0.1 0.4]
+        C = [1.0 0.0; 0.0 1.0]
+        meta = BIFMMeta(A, B, C)
+
+        H = rand(2, 2)
+        BHBt = rand(2, 2)
+        ξz = rand(2)
+        Λz = diageye(2)
+        ξztilde = rand(2)
+        Λztilde = diageye(2)
+        μu = rand(2)
+        Σu = diageye(2)
+
+        setH!(meta, H)
+        setBHBt!(meta, BHBt)
+        setξz!(meta, ξz)
+        setΛz!(meta, Λz)
+        setξztilde!(meta, ξztilde)
+        setΛztilde!(meta, Λztilde)
+        setμu!(meta, μu)
+        setΣu!(meta, Σu)
+
+        @test getH(meta) === H
+        @test getBHBt(meta) === BHBt
+        @test getξz(meta) === ξz
+        @test getΛz(meta) === Λz
+        @test getξztilde(meta) === ξztilde
+        @test getΛztilde(meta) === Λztilde
+        @test getμu(meta) === μu
+        @test getΣu(meta) === Σu
+    end
+
+    @testset "BIFM node construction and interface structure" begin
+        @test sdtype(BIFM) == Deterministic()
+
+        # TODO: test for interface indices and names. Problem: Creating factornode with node = factornode(BIFM, interfaces, factorizations) and then call getinterfaces and interfaceindex, but there is no method matching collect_factorisation(::Type{ReactiveMP.BIFM}, ::Vector{Vector{Symbol}})
+    end
+end

test/nodes/predefined/dot_product_tests.jl

@@ -0,0 +1,12 @@
+@testitem "dot node: default_meta" begin
+    using ReactiveMP
+    using MatrixCorrectionTools
+    import ReactiveMP: default_meta
+
+    # Check that `default_meta` for `dot` returns the correct type
+    meta = default_meta(dot)
+    @test meta isa MatrixCorrectionTools.ReplaceZeroDiagonalEntries
+
+    # Check that it uses the expected `tiny` value
+    @test meta.value == tiny
+end