`@rule`, `@marginalrule` and `@average_energy` should check interface names

[bvdmitri]

Together with @MagnusKoudahl we spent quite a significant amount of time just to realize that we misspelled q_A::Any and q_a::Any for some of the message update rules. It would be nice if @rule and friends would throw an error if one attempts to create a rule with misspelled input arguments.

[abpolym]

This sounds pretty easy to do. Any progress since the last 2.5 years or can I take over? 😄

[bvdmitri]

I thought I've done it already, but good to check if thats actually true and implement the checks indeed

[abpolym]

Not sure if I am blind, but I don't see any code that throws an error in any of the macros when the provided interfaces do not match any of the ones specified in the @node. For example, there are some other checks in the @rule macro, but I have no problems just defining

@rule NormalMeanVariance(:quack, Marginalisation) (m_woof::PointMass, m_blyat::PointMass) = NormalMeanVariance(mean(m_woof), mean(m_blyat))

which should not be possible if the macro actually checks the interfaces specified in the NormalMeanVariance @node:

@node NormalMeanVariance Stochastic [out, (μ, aliases = [mean]), (v, aliases = [var])]

[abpolym]

I made a new branch and am currently fixing this.

[abpolym]

Alright I have added functionality that throws an error for @rule and @marginalrule if the names of the interfaces in the @node definition do not match with the ones provided in the @rule statement.
The check also covers cases like Mixtures with switch indices, structural messages for joints like q_y_x etc.

It breaks the basic test_rule macro invokation test in test/rule_tests.jl:rule (see make test test_args="rule_tests.jl"), because LoadError: UndefVarError: TestNodeForTestRuleMacro not defined.

@bvdmitri could you have a quick look over that?

We also need to add the check for the @average_energy macro and add some tests.

Right now it will throw an error if we e.g. misname interface names:

using ReactiveMP, BayesBase, Distributions, ExponentialFamily
@rule GammaMixture((:a, k), Marginalisation) (q_out::Any, q_switche::Any, q_b::GammaDistributionsFamily) = nothing

ERROR: LoadError: ArgumentError: Rule interface mismatch for @rule GammaMixture((:a, k), Marginalisation) (q_out::Any, q_switche::Any, q_b::GammaDistributionsFamily) = nothing:
  Expected symbols: a, b, out, switch
  Provided symbols: a, b, out, switche
  Missing symbols:  switch

Stacktrace: [...]

Note that it does not throw an error (yet) if we define extra interfaces:

@rule GammaMixture((:a, k), Marginalisation) (q_out::Any, q_switch::Any, q_b::GammaDistributionsFamily, q_extra::Any) = nothing

It probably should throw an error?

Oh and I think aliases are not considered.