Skip to content

A lesson in numerical stability#484

Merged
bvdmitri merged 5 commits into
mainfrom
dt-memory-footprint
Jul 4, 2025
Merged

A lesson in numerical stability#484
bvdmitri merged 5 commits into
mainfrom
dt-memory-footprint

Conversation

@wouterwln
Copy link
Copy Markdown
Member

Softmaxing apparently helps a lot with numerical stability

@wouterwln wouterwln requested a review from bvdmitri July 4, 2025 12:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 4, 2025

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #485 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.50%. Comparing base (f117db4) to head (62682b0).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/discrete_transition/marginals.jl 57.14% 3 Missing ⚠️
...s/discrete_transition/predefined/structured_vmp.jl 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   75.49%   75.50%   +0.01%     
==========================================
  Files         200      200              
  Lines        5965     5986      +21     
==========================================
+ Hits         4503     4520      +17     
- Misses       1462     1466       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice catch :D

@bvdmitri bvdmitri merged commit 635c2f2 into main Jul 4, 2025
6 checks passed
@bvdmitri bvdmitri deleted the dt-memory-footprint branch July 4, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants