Skip to content

Fix invalidations from SnoopCompile#489

Merged
bvdmitri merged 5 commits into
mainfrom
fix-invalidations
Jul 23, 2025
Merged

Fix invalidations from SnoopCompile#489
bvdmitri merged 5 commits into
mainfrom
fix-invalidations

Conversation

@bvdmitri
Copy link
Copy Markdown
Member

This PR removes some of the methods that aren't required, but create extra burden on Julia compiler and causes compilation invalidation and extra latencies

@bvdmitri bvdmitri requested a review from wouterwln July 22, 2025 15:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.54%. Comparing base (c355e67) to head (478ae8c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/helpers/algebra/companion_matrix.jl 50.00% 2 Missing ⚠️
src/pipeline/logger.jl 66.66% 2 Missing ⚠️
src/marginal.jl 0.00% 1 Missing ⚠️
src/message.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   75.54%   75.54%   -0.01%     
==========================================
  Files         200      200              
  Lines        5987     5978       -9     
==========================================
- Hits         4523     4516       -7     
+ Misses       1464     1462       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bvdmitri bvdmitri merged commit 4d7c252 into main Jul 23, 2025
5 of 7 checks passed
@bvdmitri bvdmitri deleted the fix-invalidations branch July 23, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant