Dont check for proper in division of to accomodate inference#486
Conversation
🤖 Code FormattingYour PR still has some code formatting issues. I've updated PR #487 with the necessary formatting changes. You can merge that PR into this branch to fix the code style check. Alternatively, you can run |
|
Previously a similar change broke tests in RxInfer. I cannot see if its different? |
Yes it is. Right now we do not have a check for DivisionOf after substraction to be a proper distribution, we just raise a warning, in place of the exception. |
| ef_a_typetag = ExponentialFamily.exponential_family_typetag(ef_a) | ||
|
|
||
| resulting_nat_params = ExponentialFamily.getnaturalparameters(ef_a) - ExponentialFamily.getnaturalparameters(ef_b) + ExponentialFamily.getnaturalparameters(ef_c) | ||
| ef_resulting = ExponentialFamily.ExponentialFamilyDistribution(ef_a_typetag, resulting_nat_params, nothing, nothing) |
There was a problem hiding this comment.
@bvdmitri This line is the "main" change in this PR, that makes RxInfer test work.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 75.50% 75.54% +0.03%
==========================================
Files 200 202 +2
Lines 5986 6016 +30
==========================================
+ Hits 4520 4545 +25
- Misses 1466 1471 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This again broke the tests in RxInfer https://github.com/ReactiveBayes/RxInfer.jl/actions/runs/16963872364 |
No description provided.