Skip to content

Dont check for proper in division of to accomodate inference#486

Merged
bvdmitri merged 5 commits into
mainfrom
dont-check-for-proper-in-division-of
Jul 25, 2025
Merged

Dont check for proper in division of to accomodate inference#486
bvdmitri merged 5 commits into
mainfrom
dont-check-for-proper-in-division-of

Conversation

@Nimrais
Copy link
Copy Markdown
Member

@Nimrais Nimrais commented Jul 14, 2025

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #487 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

@bvdmitri
Copy link
Copy Markdown
Member

Previously a similar change broke tests in RxInfer. I cannot see if its different?

@Nimrais
Copy link
Copy Markdown
Member Author

Nimrais commented Jul 14, 2025

Previously a similar change broke tests in RxInfer. I cannot see if its different?

Yes it is. Right now we do not have a check for DivisionOf after substraction to be a proper distribution, we just raise a warning, in place of the exception.

ef_a_typetag = ExponentialFamily.exponential_family_typetag(ef_a)

resulting_nat_params = ExponentialFamily.getnaturalparameters(ef_a) - ExponentialFamily.getnaturalparameters(ef_b) + ExponentialFamily.getnaturalparameters(ef_c)
ef_resulting = ExponentialFamily.ExponentialFamilyDistribution(ef_a_typetag, resulting_nat_params, nothing, nothing)
Copy link
Copy Markdown
Member Author

@Nimrais Nimrais Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvdmitri This line is the "main" change in this PR, that makes RxInfer test work.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.54%. Comparing base (b9137f6) to head (7ea5332).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   75.50%   75.54%   +0.03%     
==========================================
  Files         200      202       +2     
  Lines        5986     6016      +30     
==========================================
+ Hits         4520     4545      +25     
- Misses       1466     1471       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Nimrais Nimrais requested a review from bvdmitri July 14, 2025 13:14
@bvdmitri bvdmitri merged commit fc91f0f into main Jul 25, 2025
9 checks passed
@bvdmitri bvdmitri deleted the dont-check-for-proper-in-division-of branch July 25, 2025 08:21
@bvdmitri
Copy link
Copy Markdown
Member

This again broke the tests in RxInfer https://github.com/ReactiveBayes/RxInfer.jl/actions/runs/16963872364

@bvdmitri bvdmitri restored the dont-check-for-proper-in-division-of branch August 14, 2025 12:14
@wouterwln wouterwln deleted the dont-check-for-proper-in-division-of branch September 11, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants