Skip to content

Trace ID for Events#626

Merged
fonsp merged 1 commit into
release-5from
traceID
Mar 26, 2026
Merged

Trace ID for Events#626
fonsp merged 1 commit into
release-5from
traceID

Conversation

@fonsp
Copy link
Copy Markdown
Contributor

@fonsp fonsp commented Mar 26, 2026

This PR matches ReactiveBayes/ReactiveMP.jl#589

Code written by 🤖 but I reviewed and added a test by ✋

Copy link
Copy Markdown
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fonsp fonsp merged commit 3c634a1 into release-5 Mar 26, 2026
@fonsp fonsp deleted the traceID branch March 26, 2026 12:25
bvdmitri added a commit that referenced this pull request Apr 7, 2026
…632)

* Integrate ReactiveMP event handler and enhance documentation (#615)

* initial integration of ReactiveMP event handler

* implement a more complex test

* rename event handler to callbacks to be more aligned with ReactiveMP

* update references to the callbacks in the documentation

* use ReactiveMP.invoke_callback

* fix the on_marginal_update callback invokation

* rename benchmark callbacks file

* restore the removed benchmark file lol

* make format

* checkpoint

* adapt to changes in ReactiveMP

* merge stricter formatting options

* sync with ReactiveMP

* latest changes in ReactiveMP

* allow callbacks be any structure as in ReactiveMP

* add Callbacks manual and update the related documentation

* update docs

* introduce StopIteration struct, make the callbacks use that instead of
true/false

* support benchmark = true keyword argument

* fix broken tests

* make format

* update benchmarks

* add simple tracer

* 2prev

* refactor to use ReactiveMP.Event structure

* improve the documentation

* update to latest changes in ReactiveMP

* update the debugging section

* update benchmark

* improve printing a bit

* comment-out-trace-show

* TraceEvent: turn commented Base.show into Base.summary

* Fix test to match changed TestEvent summary show method

* Store trace time to TracedEvent (#622)

* Store trace time to TracedEvent

* Update trace_tests.jl

* Apply suggestion from @bvdmitri

Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com>

---------

Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com>

* Trace ID for Events (#626)

* sprint for summary test

* partial refactor, update postprocessing and inference.jl

* update remaining files and the documentation

* fix several bugs by hand

* update the documentation build

* update docs, add migration guide, update CHANGELOG

* remove the plan

---------

Co-authored-by: Raphael-Tresor <40422324+Raphael-Tresor@users.noreply.github.com>
Co-authored-by: Fons van der Plas <fonsvdplas@gmail.com>
bvdmitri added a commit that referenced this pull request Apr 17, 2026
* Integrate ReactiveMP event handler and enhance documentation (#615)

* initial integration of ReactiveMP event handler

* implement a more complex test

* rename event handler to callbacks to be more aligned with ReactiveMP

* update references to the callbacks in the documentation

* use ReactiveMP.invoke_callback

* fix the on_marginal_update callback invokation

* rename benchmark callbacks file

* restore the removed benchmark file lol

* make format

* checkpoint

* adapt to changes in ReactiveMP

* merge stricter formatting options

* sync with ReactiveMP

* latest changes in ReactiveMP

* allow callbacks be any structure as in ReactiveMP

* add Callbacks manual and update the related documentation

* update docs

* introduce StopIteration struct, make the callbacks use that instead of
true/false

* support benchmark = true keyword argument

* fix broken tests

* make format

* update benchmarks

* add simple tracer

* 2prev

* refactor to use ReactiveMP.Event structure

* improve the documentation

* update to latest changes in ReactiveMP

* update the debugging section

* update benchmark

* improve printing a bit

* comment-out-trace-show

* TraceEvent: turn commented Base.show into Base.summary

* Fix test to match changed TestEvent summary show method

* Store trace time to TracedEvent (#622)

* Store trace time to TracedEvent

* Update trace_tests.jl

* Apply suggestion from @bvdmitri

Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com>

---------

Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com>

* Trace ID for Events (#626)

* sprint for summary test

* partial refactor, update postprocessing and inference.jl

* Revert "partial refactor, update postprocessing and inference.jl"

This reverts commit f7beb9c.

* Rename trace_id to span_id and add type parameter to RxInfer events (#634)

Mirrors the changes from ReactiveMP's better-trace-ids branch:
- Rename `trace_id::UUID` → `span_id::S` with type parameter `S` on all event structs
- Import and use `generate_span_id(callbacks)` from ReactiveMP instead of calling `uuid4()` directly
- Update convenience constructors for BeforeIterationEvent and AfterIterationEvent to accept span_id
- Update batch.jl and streaming.jl to generate span IDs via `generate_span_id`
- Update tests to reference `span_id` field

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* Refactor: rename addons to annotations (ReactiveMP v6 compatibility) (#636)

* update remaining files and the documentation

* fix several bugs by hand

* update the documentation build

* update docs, add migration guide, update CHANGELOG

* remove the plan

* fix faulty merge

* fix last test after faulty merge

* Add helpers for filtering events

* Change in event

* 2prev

* make format

* fix more tests

* added TBLogger module to create text summary from event trace

* refactor TB Logger module & remove unused imports

* add per-event-type handlers to TensorBoardLoggerExt

* render eventcounts as a table (Tensorboard)

* log time duration (ms) per iteration as time series / scalars (tensorboard)

* refactor TBLogger module to log event_types using multiple dispatching

* checkpoint

* make format

* fix tests by hand

* fix more tests

* 2prev

* documentation fixes

* add documentation for concepts similar to ReactiveMP

* delete wrongly pushed code

* fix docs build

* update docs

* update version to 5.0.0

* update ReactiveMP version constraint

* fix broken links

* initial transition to breaking changes in ReactiveMP

mostly removal of pipeline and scheduler and transitioning to the stream
postprocessors

* sync with ReactiveMP

* tests pass

* update documentation and CHANGELOG

* fix small bug

* update concepts

* update RxInferServer references

* fix small warning in the tests

* fix tensorboard test logs logging into the testing stream

* remove unused ld-rxinfer asset

* update benchmarks

* Document breaking changes for version 5.0.0

---------

Co-authored-by: Raphael-Tresor <40422324+Raphael-Tresor@users.noreply.github.com>
Co-authored-by: Fons van der Plas <fonsvdplas@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: MarcoH <marhiar@gmail.com>
Co-authored-by: RetrospectiveRotations <p.verleijsdonk@tue.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants