Skip to content

fix a bug where the challenge is reset after asw_mission_restart#931

Merged
BenLubar merged 5 commits into
reactivedrop_betafrom
bugfix/challenge-reset-after-restart
Aug 5, 2025
Merged

fix a bug where the challenge is reset after asw_mission_restart#931
BenLubar merged 5 commits into
reactivedrop_betafrom
bugfix/challenge-reset-after-restart

Conversation

@mithrand0
Copy link
Copy Markdown
Contributor

No description provided.

@mithrand0 mithrand0 requested review from BenLubar and geotavros August 5, 2025 11:43
@geotavros
Copy link
Copy Markdown
Contributor

rd_challenge ConVar has a callback UpdateMatchmakingTagsCallback(), which runs a lot of code inside of it. It needs to be reviewed to understand if it's safe to change rd_challenge like this and in what place. Sorry, but I don't have time right now to review it.

@mithrand0
Copy link
Copy Markdown
Contributor Author

rd_challenge ConVar has a callback UpdateMatchmakingTagsCallback(), which runs a lot of code inside of it. It needs to be reviewed to understand if it's safe to change rd_challenge like this and in what place. Sorry, but I don't have time right now to review it.

Thanks for pointing out UpdateMatchmakingTagsCallback(), I'll dive into it.

@mithrand0 mithrand0 closed this Aug 5, 2025
@mithrand0 mithrand0 reopened this Aug 5, 2025
@mithrand0
Copy link
Copy Markdown
Contributor Author

mithrand0 commented Aug 5, 2025

I reverted pull request #926, and added a convar, allowing me to check for this specific state.
In my opinion, this should eventually be fixed correctly, but this way it allows me to continue my other work.

TLDR: the functionality is reverted to what is was before #926

@BenLubar BenLubar merged commit 3c96eb1 into reactivedrop_beta Aug 5, 2025
4 checks passed
@BenLubar BenLubar deleted the bugfix/challenge-reset-after-restart branch August 5, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants