Skip to content

added seal icon to radial menu "request seal" item#953

Merged
BenLubar merged 6 commits into
ReactiveDrop:reactivedrop_betafrom
hpdodger:welder_icon
Nov 4, 2025
Merged

added seal icon to radial menu "request seal" item#953
BenLubar merged 6 commits into
ReactiveDrop:reactivedrop_betafrom
hpdodger:welder_icon

Conversation

@hpdodger

@hpdodger hpdodger commented Sep 1, 2025

Copy link
Copy Markdown
Contributor
image

@geotavros

Copy link
Copy Markdown
Contributor

Using the same texture as the welding icon is a little bit confusing. I think a new texture for the emote would be a better choice.

Comment thread src/game/server/swarm/asw_marine.cpp Outdated
GetMarineSpeech()->Chatter( CHATTER_THANKS );
break;
case 15:
// just request seal

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHATTER_REQUEST_SEAL_DOOR can be used here. Otherwise it will just be silence?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thank you

@hpdodger

hpdodger commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

Using the same texture as the welding icon is a little bit confusing. I think a new texture for the emote would be a better choice.

asked AstroCatNip for help to create welder emote

2. added requesting seal speech
@hpdodger

hpdodger commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author
image

new icon ai generated

@BenLubar

BenLubar commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

We can't use AI-generated content.

@hpdodger

hpdodger commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author
image

CPanelAnimationVarAliasType( int, m_nSentryDnTexture, "SentryDnTexture", "vgui/swarm/ClassIcons/SentryDismantle", "textureid" );
CPanelAnimationVarAliasType( int, m_nHackTexture, "HackTexture", "vgui/swarm/ClassIcons/HackIcon", "textureid" );
CPanelAnimationVarAliasType( int, m_nWeldTexture, "WeldTexture", "vgui/swarm/ClassIcons/WeldIcon", "textureid" );
CPanelAnimationVarAliasType(int, m_nWeldTexture, "WeldTexture", "vgui/swarm/Emotes/EmoteWelder", "textureid");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this change also changes that icon for when the actual welding happens. To fix this issue you need to create a new texture variable instead of using m_nWeldTexture

@hpdodger

hpdodger commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

thank you for patience, struggling with unfamiliar stack

@geotavros

Copy link
Copy Markdown
Contributor

Looks good from quick code review side. I didn't test it in-game. If @hpdodger tested it and it works fine then I think it can be merged.

SendPropInt ( SENDINFO( m_iEmote ), 16, SPROP_UNSIGNED ),

I assume with the current approach we're limited to 16 emotes max, so this will be the last one available.

@BenLubar

BenLubar commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

I assume with the current approach we're limited to 16 emotes max, so this will be the last one available.

The number can be increased up to 32, but until we're using all the bits, there's no point in doing so.

Plus, today's hotfix freed up all the traitor mode emote slots.

@geotavros

Copy link
Copy Markdown
Contributor

@BenLubar Do you plan to merge this one for next update?

@BenLubar BenLubar merged commit 09ba6a0 into ReactiveDrop:reactivedrop_beta Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants