refactor(tests): replace type:ignore comments with proper type annotations

Builds on PR #782 to replace the `# type: ignore` suppressions with
real type annotations and structural fixes:

- Use `isinstance(value, OnError|OnNext)` to narrow `Recorded.value` instead
  of `# type: ignore[union-attr]` (test_average, test_elementat, test_reduce,
  test_toiterable).
- Properly annotate test-local `subscribe` functions with
  `ObserverBase[T] / SchedulerBase | None / DisposableBase` and return
  `Disposable()` so `reactivex.create(...)` accepts them without
  `# type: ignore[misc]/[arg-type]` (test_concat, test_observeon, test_map,
  test_skipuntil, test_while_do).
- Type `xs` as `list[ColdObservable[int] | None]` in test_defer instead of
  bare `[None]`, and add `assert xs[0] is not None` narrowing.
- Annotate `_raise` as `NoReturn` in test_map, test_retry, test_generate so
  the surrounding code type-checks without trailing dummy returns.
- Use a typed module-level seed in test_generate to widen `Literal[0]` to
  `int` so `lambda x: x + 1` matches `Mapper[int, int]`.
- `cast(Observable[int], s)` in test_tofuture instead of `# type: ignore`.

Also widens two clearly-incorrect public type signatures (the implementation
already supports the wider input):

- `delay()` and `delay_()` now accept `AbsoluteOrRelativeTime` instead of
  only `RelativeTime`. The implementation already branches on
  `isinstance(duetime, datetime)`, so this just makes the signature match
  reality and removes 5 `# type: ignore[arg-type]` in test_delay.
- `from_callback()` now returns `Callable[..., Observable[Any]]` instead of
  `Callable[[], Observable[Any]]`. The inner `function(*args)` already
  accepts arbitrary args, so this matches reality and removes 2
  `# type: ignore[call-arg]` in test_fromcallback.

Only `test_of.py:51` keeps a `# type: ignore[call-arg]` — it's in a
test that never runs (typo `teest_` in the name) and intentionally calls
`reactivex.of()` with a kwarg that doesn't exist; fixing it is out of
scope.

Pyright strict: 0 errors. All 1494 tests pass.

Author: dbrattli

reactivex/__init__.py

@@ -469,7 +469,7 @@ def from_callable(
 def from_callback(
     func: Callable[..., Callable[..., None]],
     mapper: typing.Mapper[Any, Any] | None = None,
-) -> Callable[[], Observable[Any]]:
+) -> Callable[..., Observable[Any]]:
     """Converts a callback function to an observable sequence.
 
     Args:

reactivex/observable/fromcallback.py

@@ -8,7 +8,7 @@
 def from_callback_(
     func: Callable[..., Callable[..., None]],
     mapper: typing.Mapper[Any, Any] | None = None,
-) -> Callable[[], Observable[Any]]:
+) -> Callable[..., Observable[Any]]:
     """Converts a callback function to an observable sequence.
 
     Args:

reactivex/operators/__init__.py

@@ -707,7 +707,8 @@ def dematerialize() -> Callable[[Observable[Notification[_T]]], Observable[_T]]:
 
 
 def delay(
-    duetime: typing.RelativeTime, scheduler: abc.SchedulerBase | None = None
+    duetime: typing.AbsoluteOrRelativeTime,
+    scheduler: abc.SchedulerBase | None = None,
 ) -> Callable[[Observable[_T]], Observable[_T]]:
     """The delay operator.
 

reactivex/operators/_delay.py

@@ -20,7 +20,7 @@
 
 def observable_delay_timespan(
     source: Observable[_T],
-    duetime: typing.RelativeTime,
+    duetime: typing.AbsoluteOrRelativeTime,
     scheduler: abc.SchedulerBase | None = None,
 ) -> Observable[_T]:
     def subscribe(
@@ -119,7 +119,7 @@ def action(scheduler: abc.SchedulerBase, state: Any = None):
 @curry_flip
 def delay_(
     source: Observable[_T],
-    duetime: typing.RelativeTime,
+    duetime: typing.AbsoluteOrRelativeTime,
     scheduler: abc.SchedulerBase | None = None,
 ) -> Observable[_T]:
     """Time shifts the observable sequence.

tests/test_observable/test_average.py

@@ -1,6 +1,7 @@
 import unittest
 
 from reactivex import operators as _
+from reactivex.notification import OnError
 from reactivex.testing import ReactiveTest, TestScheduler
 
 on_next = ReactiveTest.on_next
@@ -20,7 +21,7 @@ def test_average_int32_empty(self):
         res = scheduler.start(create=lambda: xs.pipe(_.average())).messages
 
         assert len(res) == 1
-        assert res[0].value.kind == "E" and res[0].value.exception is not None  # type: ignore[union-attr]
+        assert isinstance(res[0].value, OnError) and res[0].value.exception is not None
         assert res[0].time == 250
 
     def test_average_int32_return(self):

tests/test_observable/test_concat.py

@@ -1,7 +1,9 @@
 import unittest
 
 import reactivex
+from reactivex import abc
 from reactivex import operators as ops
+from reactivex.disposable import Disposable
 from reactivex.testing import ReactiveTest, TestScheduler
 
 on_next = ReactiveTest.on_next
@@ -227,16 +229,24 @@ def test_concat_forward_scheduler(self):
         scheduler = TestScheduler()
         subscribe_schedulers: dict[str, object] = {"e1": "unknown", "e2": "unknown"}
 
-        def subscribe_e1(observer, scheduler=None):  # type: ignore[misc]
+        def subscribe_e1(
+            observer: abc.ObserverBase[int],
+            scheduler: abc.SchedulerBase | None = None,
+        ) -> abc.DisposableBase:
             subscribe_schedulers["e1"] = scheduler
             observer.on_completed()
+            return Disposable()
 
-        def subscribe_e2(observer, scheduler=None):  # type: ignore[misc]
+        def subscribe_e2(
+            observer: abc.ObserverBase[int],
+            scheduler: abc.SchedulerBase | None = None,
+        ) -> abc.DisposableBase:
             subscribe_schedulers["e2"] = scheduler
             observer.on_completed()
+            return Disposable()
 
-        e1 = reactivex.create(subscribe_e1)  # type: ignore[arg-type]
-        e2 = reactivex.create(subscribe_e2)  # type: ignore[arg-type]
+        e1 = reactivex.create(subscribe_e1)
+        e2 = reactivex.create(subscribe_e2)
 
         stream = e1.pipe(ops.concat(e2))
         stream.subscribe(scheduler=scheduler)
@@ -247,16 +257,24 @@ def subscribe_e2(observer, scheduler=None):  # type: ignore[misc]
     def test_concat_forward_none_scheduler(self):
         subscribe_schedulers: dict[str, object] = {"e1": "unknown", "e2": "unknown"}
 
-        def subscribe_e1(observer, scheduler=None):  # type: ignore[misc]
+        def subscribe_e1(
+            observer: abc.ObserverBase[int],
+            scheduler: abc.SchedulerBase | None = None,
+        ) -> abc.DisposableBase:
             subscribe_schedulers["e1"] = scheduler
             observer.on_completed()
+            return Disposable()
 
-        def subscribe_e2(observer, scheduler=None):  # type: ignore[misc]
+        def subscribe_e2(
+            observer: abc.ObserverBase[int],
+            scheduler: abc.SchedulerBase | None = None,
+        ) -> abc.DisposableBase:
             subscribe_schedulers["e2"] = scheduler
             observer.on_completed()
+            return Disposable()
 
-        e1 = reactivex.create(subscribe_e1)  # type: ignore[arg-type]
-        e2 = reactivex.create(subscribe_e2)  # type: ignore[arg-type]
+        e1 = reactivex.create(subscribe_e1)
+        e2 = reactivex.create(subscribe_e2)
 
         stream = e1.pipe(ops.concat(e2))
         stream.subscribe()

tests/test_observable/test_defer.py

@@ -2,6 +2,7 @@
 
 import reactivex
 from reactivex.testing import ReactiveTest, TestScheduler
+from reactivex.testing.coldobservable import ColdObservable
 
 on_next = ReactiveTest.on_next
 on_completed = ReactiveTest.on_completed
@@ -23,7 +24,7 @@ def _raise(ex):
 
 class TestDefer(unittest.TestCase):
     def test_defer_complete(self):
-        xs = [None]
+        xs: list[ColdObservable[int] | None] = [None]
         invoked = [0]
         scheduler = TestScheduler()
 
@@ -40,12 +41,13 @@ def defer(scheduler):
         results = scheduler.start(create)
         assert results.messages == [on_next(300, 200), on_completed(400)]
         assert 1 == invoked[0]
-        assert xs[0].subscriptions == [subscribe(200, 400)]  # type: ignore[union-attr]
+        assert xs[0] is not None
+        assert xs[0].subscriptions == [subscribe(200, 400)]
 
     def test_defer_error(self):
         scheduler = TestScheduler()
         invoked = [0]
-        xs = [None]
+        xs: list[ColdObservable[int] | None] = [None]
         ex = "ex"
 
         def create():
@@ -62,12 +64,13 @@ def defer(scheduler):
 
         assert results.messages == [on_next(300, 200), on_error(400, ex)]
         assert 1 == invoked[0]
-        assert xs[0].subscriptions == [subscribe(200, 400)]  # type: ignore[union-attr]
+        assert xs[0] is not None
+        assert xs[0].subscriptions == [subscribe(200, 400)]
 
     def test_defer_dispose(self):
         scheduler = TestScheduler()
         invoked = [0]
-        xs = [None]
+        xs: list[ColdObservable[int] | None] = [None]
 
         def create():
             def defer(scheduler):
@@ -84,7 +87,8 @@ def defer(scheduler):
         results = scheduler.start(create)
         assert results.messages == [on_next(300, 200), on_next(400, 1)]
         assert 1 == invoked[0]
-        assert xs[0].subscriptions == [subscribe(200, 1000)]  # type: ignore[union-attr]
+        assert xs[0] is not None
+        assert xs[0].subscriptions == [subscribe(200, 1000)]
 
     def test_defer_on_error(self):
         scheduler = TestScheduler()

tests/test_observable/test_delay.py

@@ -63,7 +63,7 @@ def test_delay_datetime_offset_simple1_impl(self):
 
         def create():
             dt = datetime.fromtimestamp(300.0, tz=timezone.utc)
-            return xs.pipe(delay(dt))  # type: ignore[arg-type]
+            return xs.pipe(delay(dt))
 
         results = scheduler.start(create)
         assert results.messages == [
@@ -107,7 +107,7 @@ def test_delay_datetime_offset_simple2_impl(self):
         )
 
         def create():
-            return xs.pipe(delay(datetime.fromtimestamp(250, tz=timezone.utc)))  # type: ignore[arg-type]
+            return xs.pipe(delay(datetime.fromtimestamp(250, tz=timezone.utc)))
 
         results = scheduler.start(create)
 
@@ -153,7 +153,7 @@ def test_delay_datetime_offset_simple3_impl(self):
         )
 
         def create():
-            return xs.pipe(delay(datetime.fromtimestamp(350, tz=timezone.utc)))  # type: ignore[arg-type]
+            return xs.pipe(delay(datetime.fromtimestamp(350, tz=timezone.utc)))
 
         results = scheduler.start(create)
 
@@ -201,7 +201,7 @@ def test_delay_datetime_offset_error1_impl(self):
         )
 
         def create():
-            return xs.pipe(delay(datetime.fromtimestamp(250, tz=timezone.utc)))  # type: ignore[arg-type]
+            return xs.pipe(delay(datetime.fromtimestamp(250, tz=timezone.utc)))
 
         results = scheduler.start(create)
 
@@ -244,7 +244,7 @@ def test_delay_datetime_offset_error2_impl(self):
         )
 
         def create():
-            return xs.pipe(delay(datetime.fromtimestamp(350, tz=timezone.utc)))  # type: ignore[arg-type]
+            return xs.pipe(delay(datetime.fromtimestamp(350, tz=timezone.utc)))
 
         results = scheduler.start(create)
 

tests/test_observable/test_elementat.py

@@ -1,6 +1,7 @@
 import unittest
 
 from reactivex import operators as ops
+from reactivex.notification import OnError
 from reactivex.testing import ReactiveTest, TestScheduler
 
 on_next = ReactiveTest.on_next
@@ -54,8 +55,9 @@ def create():
 
         self.assertEqual(1, len(results.messages))
         self.assertEqual(600, results.messages[0].time)
-        self.assertEqual("E", results.messages[0].value.kind)  # type: ignore[union-attr]
-        assert results.messages[0].value.exception  # type: ignore[union-attr]
+        value = results.messages[0].value
+        assert isinstance(value, OnError)
+        assert value.exception
 
     def test_elementat_error(self):
         ex = "ex"

tests/test_observable/test_empty.py

@@ -45,7 +45,10 @@ def test_empty_observer_throw_exception(self):
         scheduler = TestScheduler()
         xs = empty()
         xs.subscribe(
-            lambda x: None, lambda ex: None, lambda: _raise(Exception("ex")), scheduler=scheduler
+            lambda x: None,
+            lambda ex: None,
+            lambda: _raise(Exception("ex")),
+            scheduler=scheduler,
         )
 
         with self.assertRaises(RxException):