Skip to content

chore: fix typing exports, add operator docstring#763

Merged
dbrattli merged 1 commit into
masterfrom
repo-assist/improve-typing-exports-2026-04-18-60f123bfd9e95e24
Apr 20, 2026
Merged

chore: fix typing exports, add operator docstring#763
dbrattli merged 1 commit into
masterfrom
repo-assist/improve-typing-exports-2026-04-18-60f123bfd9e95e24

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

🤖 This is an automated PR from Repo Assist.

Summary

Three small but meaningful improvements discovered during a codebase review:

1. Fix reactivex.typing.__all__ — missing public exports

Action and StartableFactory are defined in reactivex/typing.py and used throughout the library (in Disposable, ScheduledObserver, operator signatures, NewThreadScheduler, EventLoopScheduler), but they were not listed in __all__. This means:

  • Wildcard imports (from reactivex.typing import *) silently skip them
  • Static analysis tools may not treat them as intentionally public
  • Users who want to annotate callbacks matching these signatures cannot rely on them as a stable public export

This PR adds both to __all__, making the public API contract explicit.

2. Add missing docstring to on_error_resume_next operator

The inner function in reactivex/operators/_onerrorresumenext.py had no docstring at all — the only operator inner function in the codebase completely lacking one. Added a concise docstring consistent with the pattern used by other operators.

3. Resolve accidental merge-conflict markers in changes.md

The file changes.md in master contained raw merge-conflict markers (<<<<<<, =======, >>>>>>>), indicating a previous merge was not completed correctly. Both conflicting entries are valid changelog items — one about scheduler forwarding in pairwise/to_marbles/delay_with_mapper and one about PyPy CI skip for the tkinter scheduler test. This PR includes both.

Changes

  • reactivex/typing.py: Add "Action" and "StartableFactory" to __all__
  • reactivex/operators/_onerrorresumenext.py: Add docstring to inner on_error_resume_next()
  • changes.md: Resolve conflict markers; both entries preserved; add entry for this PR

Testing

No logic changes — CI (uv run pytest, uv run pyright, uv run ruff check) should confirm no regressions.

Note

🔒 Integrity filter blocked 45 items

The following items were blocked because they don't meet the GitHub integrity level.

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Repo Assist · ● 6.3M ·

@coveralls

coveralls commented Apr 19, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 93.512%. remained the same — repo-assist/improve-typing-exports-2026-04-18-60f123bfd9e95e24 into master

@dbrattli dbrattli changed the title [Repo Assist] chore: fix typing exports, add operator docstring, resolve changes.md conflict chore: fix typing exports, add operator docstring, resolve changes.md conflict Apr 20, 2026
- Add Action and StartableFactory to reactivex.typing.__all__ so they
  are part of the explicit public API surface (they were defined but
  omitted from __all__).
- Add missing docstring to on_error_resume_next inner function in
  reactivex/operators/_onerrorresumenext.py.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dbrattli dbrattli force-pushed the repo-assist/improve-typing-exports-2026-04-18-60f123bfd9e95e24 branch from aca7b39 to 932e7b5 Compare April 20, 2026 20:18
@dbrattli dbrattli changed the title chore: fix typing exports, add operator docstring, resolve changes.md conflict chore: fix typing exports, add operator docstring Apr 20, 2026
@dbrattli dbrattli marked this pull request as ready for review April 20, 2026 20:18
@dbrattli dbrattli merged commit 8b59bc7 into master Apr 20, 2026
49 checks passed
@dbrattli dbrattli deleted the repo-assist/improve-typing-exports-2026-04-18-60f123bfd9e95e24 branch April 20, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants