chore: fix typing exports, add operator docstring#763
Merged
dbrattli merged 1 commit intoApr 20, 2026
Merged
Conversation
5 tasks
- Add Action and StartableFactory to reactivex.typing.__all__ so they are part of the explicit public API surface (they were defined but omitted from __all__). - Add missing docstring to on_error_resume_next inner function in reactivex/operators/_onerrorresumenext.py. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aca7b39 to
932e7b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Summary
Three small but meaningful improvements discovered during a codebase review:
1. Fix
reactivex.typing.__all__— missing public exportsActionandStartableFactoryare defined inreactivex/typing.pyand used throughout the library (inDisposable,ScheduledObserver, operator signatures,NewThreadScheduler,EventLoopScheduler), but they were not listed in__all__. This means:from reactivex.typing import *) silently skip themThis PR adds both to
__all__, making the public API contract explicit.2. Add missing docstring to
on_error_resume_nextoperatorThe inner function in
reactivex/operators/_onerrorresumenext.pyhad no docstring at all — the only operator inner function in the codebase completely lacking one. Added a concise docstring consistent with the pattern used by other operators.3. Resolve accidental merge-conflict markers in
changes.mdThe file
changes.mdinmastercontained raw merge-conflict markers (<<<<<<,=======,>>>>>>>), indicating a previous merge was not completed correctly. Both conflicting entries are valid changelog items — one about scheduler forwarding inpairwise/to_marbles/delay_with_mapperand one about PyPy CI skip for the tkinter scheduler test. This PR includes both.Changes
reactivex/typing.py: Add"Action"and"StartableFactory"to__all__reactivex/operators/_onerrorresumenext.py: Add docstring to inneron_error_resume_next()changes.md: Resolve conflict markers; both entries preserved; add entry for this PRTesting
No logic changes — CI (
uv run pytest,uv run pyright,uv run ruff check) should confirm no regressions.Note
🔒 Integrity filter blocked 45 items
The following items were blocked because they don't meet the GitHub integrity level.
list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".from_iterablewith a generator the generator might not be closed #546list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: