macCatalyst compile fix#2690
Closed
nighthawk wants to merge 6 commits into
Closed
Conversation
…ependencies - Use environment variable detection for Android builds (ANDROID_DATA/ANDROID_ROOT) - RxCocoa and RxCocoaRuntime targets/products are excluded on non-Darwin platforms - Use conditional dependencies to specify RxCocoaRuntime only on specific Darwin platforms
…conformances The @retroactive attribute is only needed when adding protocol conformance to types from different modules. CompletableEvent, Event, and MaybeEvent are all in the same package, so @retroactive should not be used.
Contributor
Author
|
Sorry, used the wrong base branch. Will apply to branch based on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.10.0 and 6.10.1 broke support for macCatalyst, which doesn't compile anymore due to the missing RxCocoaRuntime dependency. This is the simple fix for that.