chore: migrate to expecttype eslint rules#7416
Open
43081j wants to merge 2 commits intoReactiveX:masterfrom
Open
chore: migrate to expecttype eslint rules#741643081j wants to merge 2 commits intoReactiveX:masterfrom
43081j wants to merge 2 commits intoReactiveX:masterfrom
Conversation
Contributor
Author
|
@benlesh fyi this seems to have also caught some leftover dtslint assertions for things that have since been removed e.g. the jsdoc was also mentioning those params still, so i removed that in this PR. pinging you because you made those changes iirc, so want to be sure this is right |
43081j
commented
Jan 23, 2024
| it('should support union types', () => { | ||
| const o = of(1).pipe(expand(x => typeof x === 'string' ? of(123) : of('test'))); // $ExpectType Observable<string | number> | ||
| }); | ||
| import { of, asyncScheduler } from 'rxjs'; |
Contributor
Author
There was a problem hiding this comment.
the whitespace change seems to be that the original file had CRLF. my editor read the editorconfig and changed it to LF
This migrates to using an eslint plugin for `$ExpectType` and friends so we can do it as part of the lint script. For now, `typescript` had to be added to the root project since the rxjs site is still on an older typescript which confuses eslint (since it ends up being hoisted by yarn).
Contributor
Author
|
any chance you can take a look at this @benlesh ? 👀 low priority ofc, assuming you do want the change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates to using an eslint plugin for
$ExpectTypeand friends so we can do it as part of the lint script.For now,
typescripthad to be added to the root project since the rxjs site is still on an older typescript which confuses eslint (since it ends up being hoisted by yarn).In future, we should probably keep the two projects in sync, using the same typescript version. However, this will mean bumping the angular version in the rx site (which is its own chunky job).
Questions
tsconfig.types.json? andtsconfig.types.spec.json. im not sure what use these have anymore, as we use a separate mocha tsconfig during testing anyway