Teardown first#7448
Open
benlesh wants to merge 3 commits intoReactiveX:masterfrom
Open
Conversation
benlesh
force-pushed
the
teardown-first
branch
from
a4d4dee to
34b99f5
Compare
benlesh
force-pushed
the
teardown-first
branch
from
34b99f5 to
d8c4e84
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9a05f17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…ribe messages to closed sockets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #7443
It doesn't however revert the changes made during 8 alpha that affect operators like
first,take,some, et al. Which we'll want to do to make sure we're at parity with the web platform, and with the duals of this type. (In short: other implementations oftakewill not finalize the source before emitting the value, only before it completes)Other things:
WebSocketSubjectthat would have it try to send an unsubscribe message to the socket server when the socket server disconnected or errored.