WIP: Add script to run WPT against observable#7452
Draft
benlesh wants to merge 2 commits intoReactiveX:masterfrom
Draft
WIP: Add script to run WPT against observable#7452benlesh wants to merge 2 commits intoReactiveX:masterfrom
benlesh wants to merge 2 commits intoReactiveX:masterfrom
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 013c554. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
derdeka
reviewed
Jul 7, 2025
| }); | ||
|
|
||
| const testHarnessScriptPath = path.join(wptDir, 'resources', 'testharness.js'); | ||
| const testHarnessScript = fs.readFileSync(testHarnessScriptPath, 'utf8'); |
There was a problem hiding this comment.
ENOENT: no such file or directory on the first run as ensureWPTRepo() was not yet invoked. Should be moved to initializeTestHarness() to work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a flag in the ground for running the web platform tests against an observable polyfill from RxJS.