Skip to content

Commit 7db7e32

Browse files
authored
fix: provide a specific error message when recording permission is denied (#548)
1 parent 8fee924 commit 7db7e32

4 files changed

Lines changed: 12 additions & 1 deletion

File tree

packages/studio-web/src/app/upload/upload.component.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,15 @@ Please check it to make sure all words are spelled out completely, e.g. write "4
282282
await this.microphoneService.startRecording();
283283
this.recording = true;
284284
} catch (err: any) {
285-
this.toastr.error(err.toString(), $localize`Could not start recording!`);
285+
let message;
286+
if (err.name === "NotAllowedError") {
287+
message = $localize`Microphone access was denied. Please grant microphone access to use this feature.`;
288+
} else {
289+
message = err.toString();
290+
}
291+
this.toastr.error(message, $localize`Could not start recording!`, {
292+
timeOut: 15000,
293+
});
286294
} finally {
287295
this.starting_to_record = false;
288296
}

packages/studio-web/src/i18n/messages.es.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@
169169
"1549389605329660619": "Esto es realmente difícil. Lo intentaremos una última vez, pero puede llevar mucho tiempo y producir malos resultados. Asegúrese de que su texto coincida con su audio y que haya el menor ruido de fondo posible.",
170170
"6071928720301938306": "El procesamiento del audio falló.",
171171
"3763839702998678686": "No hay audio para descargar.",
172+
"3513286828638574591": "Permiso de micrófono denegado. Por favor, concede acceso al micrófono para grabar.",
172173
"4183225119057268962": "¡No se pudo empezar la grabación!",
173174
"2596823344081631983": "El audio se grabó con éxito. Por favor escuche su grabación para asegurarse de que está correcta y si lo está, guárdela para reusarla luego.",
174175
"1317075918959775059": "¡Hurra!",

packages/studio-web/src/i18n/messages.fr.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@
169169
"1549389605329660619": "C'est vraiment difficile. Nous allons essayer une dernière fois, mais ça peut être long et donner de mauvais résultats. Veuillez vous assurer que votre texte correspond à votre audio et qu'il y a le moins de bruit de fond possible.",
170170
"6071928720301938306": "Échec de traitement de l'audio.",
171171
"3763839702998678686": "Pas d'audio à télécharger.",
172+
"3513286828638574591": "Autorisation du micro refusée. Prière d'accorder l'accès au micro pour pouvoir enregistrer.",
172173
"4183225119057268962": "Impossible de démarrer l'enregistrement!",
173174
"2596823344081631983": "Audio enregistré avec succès. Prière d'écouter votre enregistrement pour le valider et de le sauvegarder s'il est bon.",
174175
"1317075918959775059": "Bravo!",

packages/studio-web/src/i18n/messages.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@
169169
"1549389605329660619": "This is really difficult. We'll try one last time, but it might take a long time and produce poor results. Please make sure your text matches your audio and that there is as little background noise as possible.",
170170
"6071928720301938306": "Audio processing failed.",
171171
"3763839702998678686": "No audio to download.",
172+
"3513286828638574591": "Microphone access was denied. Please grant microphone access to use this feature.",
172173
"4183225119057268962": "Could not start recording!",
173174
"2596823344081631983": "Audio was successfully recorded. Please listen to your recording to make sure it's OK, and save it for reuse if so.",
174175
"1317075918959775059": "Yay!",

0 commit comments

Comments
 (0)