Skip to content

Commit e7d6410

Browse files
committed
perf(ci): separate the playwright install and run steps
This allows us to let the servers start while playwright browsers are downloading, which means we don't need to sleep 50s just waiting for the servers to start.
1 parent 27fda3e commit e7d6410

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/end-to-end-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,18 +99,18 @@ jobs:
9999
npx nx build web-component
100100
npx nx run-many --targets=serve,serve-fr,serve-es --projects=web-component,studio-web --parallel 6 &
101101
102+
- name: Install Playwright browsers
103+
run: npx playwright install --with-deps chromium
104+
102105
- name: Wait for the servers to be up
103106
run: |
104107
# wait for the studio web to be up
105-
sleep 50
106108
curl --retry 20 --retry-delay 10 --retry-all-errors http://localhost:4200 > /dev/null
107109
# Make sure the back-end API is up too
108110
curl --retry 20 --retry-delay 1 --retry-all-errors http://localhost:8000/api/v1/langs
109111
110112
- name: Run Playwright tests for studio-web
111-
run: |
112-
npx playwright install --with-deps chromium
113-
npx nx e2e studio-web
113+
run: npx nx e2e studio-web
114114

115115
- name: Upload HTML report
116116
uses: actions/upload-artifact@v6

0 commit comments

Comments
 (0)